Skip to content

Fix run service job renewal retry - #4671

Open
ishu599 wants to merge 1 commit into
actions:mainfrom
ishu599:main
Open

Fix run service job renewal retry#4671
ishu599 wants to merge 1 commit into
actions:mainfrom
ishu599:main

Conversation

@ishu599

@ishu599 ishu599 commented Sep 3, 2026

Copy link
Copy Markdown

Fixes #4635.

Run Service job renewal could throw a NullReferenceException when a renewal failed after a previous renewal had succeeded.

The retry path was using request.LockedUntil, but request is never initialized in the IRunServer renewal flow. This caused the renewal task to fail and the active job to be abandoned.

This change:

  • Tracks the LockedUntil value from the last successful renewal.
  • Uses the last successful lock expiration when calculating the retry time.
  • Updates the retry logging to use the last successful lock expiration.
  • Adds a regression test covering a successful renewal followed by a generic failure and a successful retry.

Testing

  • Added a regression test for Run Service job renewal retry.
  • Verified the test passes with the fix.
  • Verified the test fails with the previous implementation due to NullReferenceException.

@ishu599
ishu599 requested a review from a team as a code owner September 3, 2026 20:24
@ishu599

ishu599 commented Sep 3, 2026

Copy link
Copy Markdown
Author

check plz
nullreference issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Service renewal throws NullReferenceException after a post-success failure and abandons the active job

1 participant