feat(sql_workbench): add DM datasource type mapping and support check#599
Merged
feat(sql_workbench): add DM datasource type mapping and support check#599
Conversation
… #780 - Add "达梦(DM)" -> "DM" case in convertDBType() for ODC DialectType mapping - Add pkgConst.DBTypeDM to SupportDBType() whitelist - Add table-driven unit tests for both functions (14 test cases)
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨No code suggestions found for the PR. |
BugsGuru
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
convertDBType(): maps "达梦(DM)" to ODC DialectType "DM"pkgConst.DBTypeDMtoSupportDBType()whitelist for SQL workbench supportconvertDBType()andSupportDBType()functionsFixes https://github.com/actiontech/dms-ee/issues/780
Description
增加 "达梦(DM)" 数据库类型映射支持
更新 SupportDBType 白名单,增加 pkgConst.DBTypeDM
添加单元测试验证转换逻辑和支持检查
Diagram Walkthrough
File Walkthrough
sql_workbench_service.go
增加达梦数据库类型映射与支持检查internal/sql_workbench/service/sql_workbench_service.go
sql_workbench_service_test.go
新增单元测试验证达梦支持功能internal/sql_workbench/service/sql_workbench_service_test.go