fix: make password field optional when adding data source#601
Open
LordofAvernus wants to merge 1 commit intomainfrom
Open
fix: make password field optional when adding data source#601LordofAvernus wants to merge 1 commit intomainfrom
LordofAvernus wants to merge 1 commit intomainfrom
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
validate:"required"from Password field in DBService API (v1 and v2) to support data sources that may not require password authenticationFixes https://github.com/actiontech/sqle-ee/issues/2738
Description
修改 v1 中密码字段校验设置
修改 v2 中密码字段校验设置
使密码字段变为可选
Diagram Walkthrough
File Walkthrough
db_service.go
v1 接口密码字段设置修改api/dms/service/v1/db_service.go
db_service.go
v2 接口密码字段设置修改api/dms/service/v2/db_service.go