Skip to content

Publish only a whitelist of files in the gem #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fivell merged 5 commits into from
Sep 30, 2026
Merged

Publish only a whitelist of files in the gem #226

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e6f8b8
Keep specs and CI config out of the packaged gem
Fivell Sep 30, 2026
c4c23c5
Switch spec.files to a whitelist
Fivell Sep 30, 2026
a5b3741
Select the whitelist through git rather than Dir
Fivell Sep 30, 2026
106cd0d
Keep bin/ selectable so executables cannot silently vanish
Fivell Sep 30, 2026
f994a06
Whitelist every root a Rails engine loads from, not just the ones in use
Fivell Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion active_admin_import.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ Gem::Specification.new do |gem|
gem.homepage = 'https://github.com/activeadmin-plugins/active_admin_import'
gem.license = 'MIT'
gem.required_ruby_version = '>= 3.3.0'
gem.files = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR)
# Whitelist, not a reject list: a new directory in the repo does not
# reach consumers until it is named here. The reject form needs a new
# pattern every time the repo grows one, and that is how spec/ and
# .github/ ended up published in the first place.
gem.files = `git ls-files -z -- lib app vendor config exe bin README.md LICENSE`.split("\x0")
gem.executables = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
gem.name = 'active_admin_import'
gem.require_paths = ['lib']
Expand Down
Loading