Conversation
Rails 7.2 reached end of life on 2026-08-09 (endoflife.date/rails), so the SQLite matrix now tests Rails 8.0 and 8.1 only. The ActiveAdmin 4 include leg that pinned Rails 7.2.0 goes with it. Both `exclude:` rules are also removed. Their stated reason -- "ActiveAdmin 3.2.0 predates Rails 8 support" -- is stale: the matrix pins `~> 3.2.0`, which resolves to activeadmin 3.2.5, and that installs and passes the suite on both Rails 8.0.5.1 and 8.1.4 (66 examples, 0 failures each). The rules were hiding working coverage. The two PostgreSQL jobs move from Rails 8.0.0 to 8.1.0, both verified locally against a real PostgreSQL. The MySQL job stays on 8.0.0, which is supported until 2026-11-07, so one DB-backed job still covers the oldest supported Rails.
Member
Author
|
Probe done, closing without merging. The MySQL job passes on Rails 8.1: The change is now on #228, so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway branch. The only purpose is to let the GitHub runner's
mysql:8.0service answer a question that could not be answered locally: does the MySQL-backed job pass on Rails 8.1?Context: PR #228 moved the PostgreSQL jobs to Rails 8.1 but deliberately left
test-mysqlon 8.0, because no MySQL server was available locally and pushing an unverified change was the wrong trade. This probe closes that gap. If the MySQL job is green here, the change moves onto #228 and this PR is closed without merging.Rails 8.0 goes EOL 2026-11-07, which is why the job should not stay there.