Skip to content

Exclude the root-mounted suite from a bare rspec run - #20

Merged
Fivell merged 1 commit into
mainfrom
fix/rspec-exclude-root-suite
Sep 30, 2026
Merged

Fivell merged 1 commit into
mainfrom
fix/rspec-exclude-root-suite

Conversation

@Fivell

@Fivell Fivell commented Sep 30, 2026

Copy link
Copy Markdown
Member

Follow-up to #17, from Copilot's review of it.

.rspec was updated for the engine and isolated-engine suites but never for the root-mounted one that #17 added, so:

--exclude-pattern "spec/{engine,isolated,dummy_engine,dummy_isolated}/**/*"

A bare bundle exec rspec therefore loaded spec/root alongside the default suite and booted spec/dummy and spec/dummy_root in the same process — two Rails applications, one Rails.application.

CI never caught it because CI runs the rake tasks, and Rakefile already had the right exclusion:

t.exclude_pattern = "spec/{engine,isolated,root,dummy_engine,dummy_isolated,dummy_root}/**/*"

This is the same list in .rspec, plus the comment above it updated to name all four suites.

bundle exec rspec with no arguments: 161 examples, 0 failures, 1 pending.

`.rspec` still listed only the engine and isolated-engine suites, so
`bundle exec rspec` with no arguments loaded spec/root alongside the
default suite and booted two dummy Rails apps in one process. The rake
tasks were already correct; this is the same exclusion for the plain
command.
@Fivell
Fivell merged commit b47afe4 into main Sep 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant