Exclude the root-mounted suite from a bare rspec run - #20
Merged
Merged
Conversation
`.rspec` still listed only the engine and isolated-engine suites, so `bundle exec rspec` with no arguments loaded spec/root alongside the default suite and booted two dummy Rails apps in one process. The rake tasks were already correct; this is the same exclusion for the plain command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17, from Copilot's review of it.
.rspecwas updated for the engine and isolated-engine suites but never for the root-mounted one that #17 added, so:A bare
bundle exec rspectherefore loadedspec/rootalongside the default suite and bootedspec/dummyandspec/dummy_rootin the same process — two Rails applications, oneRails.application.CI never caught it because CI runs the rake tasks, and
Rakefilealready had the right exclusion:This is the same list in
.rspec, plus the comment above it updated to name all four suites.bundle exec rspecwith no arguments: 161 examples, 0 failures, 1 pending.