Skip to content

Drop EOL Ruby and Rails from CI #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fivell merged 3 commits into from
Oct 1, 2026
Merged

Drop EOL Ruby and Rails from CI #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c69f734
ci: drop EOL Ruby from the matrix
Fivell Oct 1, 2026
ee69968
chore: move the gemfiles off EOL Rails
Fivell Oct 1, 2026
b9860cf
chore: raise the gemspec Ruby floor to 3.3
Fivell Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['3.2', '3.3', '3.4']
ruby: ['3.3', '3.4', '4.0']
gemfile:
- gemfiles/activeadmin_3.5.gemfile
- gemfiles/activeadmin_4.0.gemfile
Expand Down
2 changes: 1 addition & 1 deletion activeadmin-oidc.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
spec.license = "MIT"
spec.homepage = "https://github.com/activeadmin-plugins/activeadmin-oidc"

spec.required_ruby_version = ">= 3.2.0"
spec.required_ruby_version = ">= 3.3.0"

spec.files = Dir[
"lib/**/*",
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activeadmin_3.5.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gemspec path: ".."

# ActiveAdmin 3.5 line: classic Sprockets + Sassc asset pipeline.
gem "activeadmin", "~> 3.5.0"
gem "rails", "~> 7.2.0"
gem "rails", "~> 8.0.0"

# openid_connect 1.x line (httpclient-based, no faraday dep). Pinning the
# 0.6.x series here keeps CI exercising the pre-faraday strategy path.
Expand Down
3 changes: 3 additions & 0 deletions gemfiles/activeadmin_4.0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ gemspec path: ".."
# the Sprockets/Sassc pipeline with Propshaft + importmap + cssbundling +
# Tailwind, so the asset gems differ entirely from the 3.5 gemfile.
gem "activeadmin", ">= 4.0.0.beta", "< 5"
# Blocked on Rails 8.1: railties 8.1 calls `delegate_missing_to` in
# Rails::Initializable::Collection without requiring the ActiveSupport
# core ext, so this gem's `require "rails/railtie"` raises NoMethodError.
gem "rails", "~> 8.0.0"

# openid_connect 2.x line (faraday 2.x).
Expand Down
Loading