Release 3.0.0 - #25
Merged
Merged
Conversation
Co-Authored-By: Clanker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version to 3.0.0. Merge after #24.
Major because three changes can break a working host.
Upgrade notes
Configuration::DEFAULT_LOGIN_PATHandDEFAULT_LOGOUT_PATHare removed. ReadActiveAdmin::Oidc.config.login_pathandlogout_pathinstead (Derive every mounted path from ActiveAdmin's namespace #17).:admin: the login, logout and OmniAuth paths now follow the namespace. Withdefault_namespace = :backoffice, the callback moves from/admin/auth/oidc/callbackto/backoffice/auth/oidc/callback. Register the new callback URL with your identity provider, and updatec.redirect_uriif you set it. To keep the old URLs, setc.login_path,c.logout_pathandc.omniauth_path_prefixto the/adminvalues (Derive every mounted path from ActiveAdmin's namespace #17, Follow a host-set Devise.omniauth_path_prefix in the strategy too #21).Hosts on the default
:adminnamespace need no changes.Fixes
devise.rbsetsomniauth_path_prefix(Follow a host-set Devise.omniauth_path_prefix in the strategy too #21).:"admin-panel"route to/admin_panel, as ActiveAdmin does (Follow a host-set Devise.omniauth_path_prefix in the strategy too #21).require "activeadmin-oidc"no longer raises on Rails 8.1 (Fix NoMethodError on Rails 8.1 and move the ActiveAdmin 4.0 leg to it #23).omniauth_route_prefixoption for engine-mounted Devise (Derive every mounted path from ActiveAdmin's namespace #17).