Repository navigation
Sort RuboCop config and configure cops explicitly - #742
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #742 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 17 17
Lines 459 459
=======================================
Hits 433 433
Misses 26 26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tagliala
changed the title
tagliala
force-pushed
the
chore/sort-rubocop
branch
from
September 18, 2026 14:09
ecc4518 to
07c4b9f
Compare
Drop the Capybara:, Performance:, and RSpec: department blocks. Verified with a --show-cops comparison (all 799 cops identical before and after): the Capybara and Performance blocks were no-ops because every registered cop in those departments is already listed. The RSpec block, however, implicitly enabled four unlisted cops - RSpec/EmptyOutput, RSpec/ExpectInLet, RSpec/MissingExpectationTargetMethod, and RSpec/UndescriptiveLiteralsDescription - which are now listed explicitly to preserve that behavior. Capybara/AmbiguousClick was NOT explicitly enabled: rubocop-capybara ships it as Enabled: false and the department block does not override that here, so it is not enforced by this project today. Forcing it on would introduce new offenses, so it stays unlisted rather than enabled. Metrics: Enabled: false is kept as a department-level disable, which also covers future Metrics cops without risk of auto-enabling anything. This is preliminary work toward including all cops explicitly in the configuration to synchronize with modern RuboCop versions.
tagliala
force-pushed
the
chore/sort-rubocop
branch
from
September 18, 2026 14:33
07c4b9f to
8363160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related changes to
.rubocop.yml:Capybara:,Performance:, andRSpec:are dropped.Motivation
This is preliminary work toward including all cops explicitly in the configuration to synchronize with modern RuboCop versions.
Verified with a full
--show-copscomparison (all 799 cops identical to master before this change): theCapybara:andPerformance:blocks were no-ops because every registered cop in those departments is already listed individually. TheRSpec: Enabled: trueblock, however, was implicitly enablingRSpec/EmptyOutput,RSpec/ExpectInLet,RSpec/MissingExpectationTargetMethod, andRSpec/UndescriptiveLiteralsDescription— so removing it would have disabled them. Those four are now listed explicitly to preserve behavior, andCapybara/AmbiguousClickis left unlisted (it stays disabled via its plugin default, which is what the block produced anyway).Metrics: Enabled: falseis retained as a single department-level disable.