This repository was archived by the owner on Mar 30, 2022. It is now read-only.
Fix Reported issue involving reoder and last#419
Open
yez wants to merge 1 commit intoactiverecord-hackery:masterfrom
Open
Fix Reported issue involving reoder and last#419yez wants to merge 1 commit intoactiverecord-hackery:masterfrom
yez wants to merge 1 commit intoactiverecord-hackery:masterfrom
Conversation
Author
|
The build passed on my fork, looks like this one failed due to some kind of download issue. If someone could restart the build, it will probably pass. |
This should Resolve activerecord-hackery#418 Since the 4.1 version of `reverse_order!` is used, an additional check has been added to actually reorder the `ORDER BY` clause if there are non-nil elements of it. Additionally, a spec has been added to ensure proper ordering takes place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bigxiang
This should Resolve #418
Since the 4.1 version of
reverse_order!is used, an additional check has beenadded to actually reorder the
ORDER BYclause if there are non-nil elementswithin it.
Additionally, a spec has been added to ensure proper ordering takes place.