Repository navigation
bitmaptools: readinto() reads whole rows from streams like sockets - #11627
Merged
dhalbert merged 1 commit intoOct 18, 2026
Merged
Conversation
readinto() read each row with one call and took a short read as the end of the file. A socket returns what has arrived, so a row split across TCP segments raised EOFError. It now reads until the row is complete, with mp_stream_read_exactly(), as jpegio and audiocore do. On a PicoPad (RP2040), a 312x276 4-bit BMP streamed from a socket into a Bitmap now takes about 0.63 s instead of 2.2 s for the same decode in Python, with the same pixels. Reading from a file is unchanged. +16 bytes.
Author
|
Related: adafruit/Adafruit_CircuitPython_Requests#219 adds Response.raw. I have a follow-up to this PR that lets bitmaptools.readinto() also take objects with a readinto() method, like Response.raw or adafruit_esp32spi sockets. On a PicoPad that loads a 43 KB page from Requests into a Bitmap in about 0.72 s instead of 2.55 s. |
dhalbert
enabled auto-merge
October 18, 2026 23:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readinto()read each row with one call and treated a short read as end of file. A socket returns what has arrived, so a row split across TCP segments raised EOFError. It now reads until the row is complete withmp_stream_read_exactly(), like jpegio and audiocore.Tested on a PicoPad (RP2040): a 312×276 4-bit BMP streamed from a socket into a Bitmap takes about 0.63 s, against 2.2 s for the same decode in Python, with identical pixels. Reading from a file is unchanged. Flash: +16 bytes