Skip to content

[pull] main from nodejs:main #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Mar 2, 2026
Merged

[pull] main from nodejs:main #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ade0bad
blog: clarify contact method for low signal researchers (#8613)
UlisesGascon Mar 2, 2026
68ddb10
chore(remark-lint): better invalid type regex (#8673)
avivkeller Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/site/pages/en/blog/announcements/hackerone-signal-requirement.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ submissions.

- **New researchers or researchers with [signal][Signal] >= 1.0**: You can continue reporting vulnerabilities through HackerOne as usual
- **Those below the threshold**: You can still reach the security team through the
[OpenJS Foundation Slack](https://slack-invite.openjsf.org/). Contact us there to discuss potential
vulnerabilities
[OpenJS Foundation Slack](https://slack-invite.openjsf.org/) (channel: `#nodejs-security-wg` for help). Contact us directly using direct messages there to discuss potential vulnerabilities. You can find the users listed in [security release stewards](https://github.com/nodejs/node#security-release-stewards).

## About HackerOne Signal

Expand Down
2 changes: 1 addition & 1 deletion packages/remark-lint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@node-core/remark-lint",
"type": "module",
"version": "1.2.0",
"version": "1.2.1",
"exports": {
".": "./src/index.mjs",
"./api": "./src/api.mjs"
Expand Down
5 changes: 5 additions & 0 deletions packages/remark-lint/src/rules/__tests__/invalid-type-reference.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ const testCases = [
'Type reference should be separated by "|", without spaces; saw "{string | boolean}"',
],
},
{
name: 'newline, multiple references',
input: 'Psst, are you a {string|\nboolean}',
expected: [],
},
{
name: 'invalid references',
input: 'This is {invalid}.',
Expand Down
4 changes: 2 additions & 2 deletions packages/remark-lint/src/rules/invalid-type-reference.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import createQueries from '@nodejs/doc-kit/src/utils/queries/index.mjs';
import { lintRule } from 'unified-lint-rule';
import { visit } from 'unist-util-visit';

const MATCH_RE = /\s\||\|\s/g;
const REPLACE_RE = /\s*\|\s*/g;
const MATCH_RE = /\s\||\| /g;
const REPLACE_RE = /\s*\| */g;

/**
* Ensures that all type references are valid
Expand Down
Loading