chore: remove the embargo guard - #62
Merged
Merged
Conversation
The embargo was lifted 2026-08-29; the guard is no longer needed (operator decision 2026-08-30). Removes all five parts, since leaving any one of them still blocks a commit or a push: - .githooks/pre-commit and .githooks/commit-msg - scripts/embargo-guard.mjs and its test - the `embargo` CI job (which existed because the local hooks are bypassable with --no-verify) - the gitignored denylist entry and the .claude chmod permission - the README section documenting the one-time clone setup `core.hooksPath` is unset locally and the local denylist file is deleted. REQUIRES A REPO-SETTINGS CHANGE TO MERGE: `embargo guard` is still a required status check on main, so this PR cannot merge until that check is removed from branch protection. The EMBARGO_GUARD_CONFIG repo secret is also now unused.
Resolves two conflicts, both in files this branch edited while #49 was landing on main. - .gitignore: this branch deleted the embargo denylist block; main added a root-level `node_modules/` rule immediately after it. Kept main's addition, dropped the embargo lines. - docs/STATUS.md: both sides rewrote the same TL;DR. Took main's version, which is newer and richer, and folded in the embargo-guard removal plus the fact that `embargo guard` has been dropped from the branch-protection required checks. Also corrected one clause main itself made stale by merging #49 — it still described the PR as awaiting a merge decision. Verified the merge kept the guard removed rather than resurrecting it: .githooks/, scripts/embargo-guard.mjs and the `embargo` CI job are all still absent.
Telltale now lives at adbarc92/telltale, extracted with git subtree split so all 17 commits kept their TDD and review history. Verified before pushing: 82 passed / 1 skipped, tsc --noEmit exit 0. Also records that the handoff's step 3 was a no-op. telltale/ never existed on main or on this branch — only on PR #64's branch — so closing that PR rather than merging it left nothing to strip, the vitest (telltale) CI job included. #64 and #63 are both closed.
Owner
Author
|
Three commits added to this branch beyond the embargo-guard removal, as part of the Telltale pivot (#64):
The first two existed only on #64's branch. Since #64 is being closed rather than merged, they would have been lost with it, so they were cherry-picked here (both docs-only — neither touches Worth recording: the handoff's "strip Telltale out of command-center" step was a no-op. Docs only. Required check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embargo was lifted 2026-08-29; the guard is no longer needed (operator decision 2026-08-30).
What this removes
It was five parts, not one hook — leaving any one of them would still block a commit or a push:
.githooks/pre-commit+commit-msgscripts/embargo-guard.mjs+ its testembargoCI job--no-verify.claudechmod permissioncore.hooksPathwas unset locally and.embargo-guard.local.jsondeleted (both local-only, not in this diff).Branch protection — already handled
embargo guardwas a required status check onmain. Deleting the CI job alone would have left every PR — including this one — hanging forever on a check that no longer reports.It has already been dropped from branch protection. Required checks are now
["cargo test (workspace)"], withstrictpreserved. No action needed to merge.Also
docs/STATUS.md's state summary is corrected, since it claimedembargo guardas a required check. Older session-log entries are left alone as frozen history.EMBARGO_GUARD_CONFIGrepo secret is now unused. Deleting it is irreversible and costs nothing to keep, so it was left in place.