fix: eliminate comply tester false positive observations#417
Open
sliss wants to merge 1 commit intoadcontextprotocol:mainfrom
Open
fix: eliminate comply tester false positive observations#417sliss wants to merge 1 commit intoadcontextprotocol:mainfrom
sliss wants to merge 1 commit intoadcontextprotocol:mainfrom
Conversation
- Skip snapshot-only get_media_buys previews (no `status` field) when checking valid_actions and sandbox, preventing false warnings - Handle nested media_buy response envelope when extracting canceled_by and canceled_at from cancel step previews - Suppress schema validation stderr for comply_test_controller responses that intentionally return non-standard error codes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
IPR Policy Agreement RequiredThank you for your contribution! Before we can accept your pull request, you must agree to our Intellectual Property Rights Policy. By making a Contribution, you agree that:
To agree, please comment below with the exact phrase: You can read the full IPR Policy here. I have read the IPR Policy You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_media_buyspreviews (which lack astatusfield) when checking forvalid_actionsandsandboxin the observation builder. Snapshot previews intentionally omit these fields, causing false warnings.media_buyresponse envelope when extractingcanceled_by,canceled_at, andrevisionfrom the cancel step intestMediaBuyLifecycle, matching howextractStatusalready handles nesting.Schema validation failed for comply_test_controllerconsole output duringcallControllercalls, since the controller intentionally returns non-standard error codes (UNKNOWN_SCENARIO,INVALID_PARAMS,NOT_FOUND) that fail schema validation.Test plan
adcp complyagainst OpenAds test server and confirm no false positive advisories forvalid_actions,sandbox, orcanceled_by🤖 Generated with Claude Code