Skip to content

fix: eliminate comply tester false positive observations#417

Open
sliss wants to merge 1 commit intoadcontextprotocol:mainfrom
sliss:fix/comply-observation-false-positives
Open

fix: eliminate comply tester false positive observations#417
sliss wants to merge 1 commit intoadcontextprotocol:mainfrom
sliss:fix/comply-observation-false-positives

Conversation

@sliss
Copy link
Copy Markdown

@sliss sliss commented Apr 2, 2026

Summary

  • valid_actions / sandbox false positives: Skip snapshot-only get_media_buys previews (which lack a status field) when checking for valid_actions and sandbox in the observation builder. Snapshot previews intentionally omit these fields, causing false warnings.
  • canceled_by false positive: Handle nested media_buy response envelope when extracting canceled_by, canceled_at, and revision from the cancel step in testMediaBuyLifecycle, matching how extractStatus already handles nesting.
  • Controller validation stderr noise: Suppress Schema validation failed for comply_test_controller console output during callController calls, since the controller intentionally returns non-standard error codes (UNKNOWN_SCENARIO, INVALID_PARAMS, NOT_FOUND) that fail schema validation.

Test plan

  • Run adcp comply against OpenAds test server and confirm no false positive advisories for valid_actions, sandbox, or canceled_by
  • Confirm no noisy stderr from expected controller error responses
  • Verify all existing scenarios still pass (no regressions)

🤖 Generated with Claude Code

- Skip snapshot-only get_media_buys previews (no `status` field) when
  checking valid_actions and sandbox, preventing false warnings
- Handle nested media_buy response envelope when extracting canceled_by
  and canceled_at from cancel step previews
- Suppress schema validation stderr for comply_test_controller responses
  that intentionally return non-standard error codes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

IPR Policy Agreement Required

Thank you for your contribution! Before we can accept your pull request, you must agree to our Intellectual Property Rights Policy.

By making a Contribution, you agree that:

  • You grant the Foundation a perpetual, irrevocable, worldwide, non-exclusive, royalty-free copyright license to your Contribution
  • You grant a patent license under any Necessary Claims
  • You represent that you own or have sufficient rights to grant these licenses

To agree, please comment below with the exact phrase:

I have read the IPR Policy

You can read the full IPR Policy here.


I have read the IPR Policy


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant