fix: activate Reporting compliance track with dedicated scenarios#1782
Merged
fix: activate Reporting compliance track with dedicated scenarios#1782
Conversation
The Reporting track was permanently stuck at EXPECTED status because TRACK_SCENARIOS['reporting'] was an empty array with a hard-coded special case. Map it to full_sales_flow (which already tests get_media_buy_delivery when the agent exposes that tool) and remove the dead 'expected' status from types and rendering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 31, 2026
Bump @adcp/client to ^4.19.0 and map the reporting compliance track to ['reporting_flow', 'deterministic_delivery'] instead of ['full_sales_flow']. This gives precise evaluation of reporting capabilities rather than piggybacking on the broader sales flow. Closes adcontextprotocol/adcp-client#412 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
buildScenarioList filtered against DEFAULT_SCENARIOS, which silently dropped reporting_flow and deterministic_delivery since they aren't in the client's default list. Now appends track-specific scenarios after the default ordering. Added integration test to catch this class of bug. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bokelley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXPECTEDstatus because it had no test scenarios wired up@adcp/clientto ^4.19.0 for the dedicatedreporting_flowanddeterministic_deliveryscenariosbuildScenarioListto include track-specific scenarios not inDEFAULT_SCENARIOS(without this fix, the new scenarios were silently filtered out)'expected'track status from types, rendering, and logicContext
ONX seller agent (Greg Morey) reported that Reporting track stayed at EXPECTED despite correct capabilities declaration and passing all other tracks. Root cause:
TRACK_SCENARIOS['reporting']was an empty array with a hard-coded special case returning'expected'.Test plan
reporting_flow+deterministic_deliverybuildScenarioList(['reporting'])includes both scenariosbuildScenarioList()includes all track scenarios🤖 Generated with Claude Code