fix(server): add CORS headers to handleChat error responses#24
Open
anfibiacreativa wants to merge 1 commit intomainfrom
Open
fix(server): add CORS headers to handleChat error responses#24anfibiacreativa wants to merge 1 commit intomainfrom
anfibiacreativa wants to merge 1 commit intomainfrom
Conversation
The Invalid JSON (400) and Invalid request body (400) early-return paths in handleChat were missing CORS_HEADERS, unlike every other response in the file. A Zod validation failure (e.g. missing path in pageContext) would return a 400 without Access-Control-Allow-Origin, causing the browser to block the response entirely and surface a misleading CORS error. Also relax PageContextSchema.path to optional (defaults to '') so a missing path never triggers a validation failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Invalid JSON (400) and Invalid request body (400) early-return paths in handleChat were missing CORS_HEADERS, unlike every other response in the file. A Zod validation failure (e.g. missing path in pageContext) would return a 400 without Access-Control-Allow-Origin, causing the browser to block the response entirely and surface a misleading CORS error.
Also relax PageContextSchema.path to optional (defaults to '') so a missing path never triggers a validation failure.