Migrate ExternalProject to FetchContent #1787
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LecrisUT
commented
Jun 7, 2025
| set_property(TARGET shared PROPERTY CXX_STANDARD 17) | ||
|
|
||
| target_include_directories(shared PRIVATE include resource) | ||
| target_link_libraries(shared PUBLIC LibXml2::LibXml2) |
Author
There was a problem hiding this comment.
About this thing, c/shared/include/ctlshare.h has an #include <libxml/tree.h> so all consumers of shared includes must propagate the libxml includes, thus the PUBLIC linkage here. The issue is that the consumers of the includes do not consume shared, instead they consume the includes via target_include_directories(rotatefont PRIVATE ../shared/include) which bypasses the modern CMake designs. Could you look into fixing these issues?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1784 for more details
There are some design changes that I want to highlight here that should be resolved earlier on