Added Table component support in Core Components by armaang1729 · Pull Request #1879 · adobe/aem-core-forms-components

armaang1729 · 2026-05-11T11:14:19Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2026-05-12T05:23:02Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2026-05-12T05:43:15Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-05-13T07:32:10Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

codecov · 2026-05-19T05:57:40Z

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../components/internal/models/v1/form/TableImpl.java	93.93%	0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

armaang1729 · 2026-05-19T06:04:07Z

        'checkbox-group': fieldTypes.SELECT,
        'checkbox': fieldTypes.CHECKBOX,
        'date-input': fieldTypes.TEXT,
+        'datetime-input': fieldTypes.TEXT,


NOTE :

Previously, the replace dialog restricted targets to the same typeMap family (e.g. text-input could only be replaced with TEXT-family components). This was too limiting inside table row cells where any policy-allowed component should be swappable.

Changes:

isUnderCoreTableRow: detects when the editable is inside a table row/header and skips the type-family check entirely for those cells.

buildAllowedTemplatePathSet: still enforces the parent container's policy, so only components the row actually allows appear in the list.

getTemplateFieldType + null guard: fixes a crash when a component's .json omits fieldType — now falls back to model.json.

Added datetime-input and multiline-input to typeMap so they match correctly in standard (non-table) replace flows.

adobe-bot · 2026-05-19T06:25:47Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-05-19T06:27:53Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

armaang1729 · 2026-05-19T09:53:15Z

@@ -0,0 +1,1108 @@
+/*******************************************************************************


NOTE :

Author-side editor hook for the core table component. Powers all structural editing actions on a table in the AEM page editor — add/delete/reorder rows, add/delete columns, and merge/split cells — by making Sling POST requests to manipulate JCR nodes directly and refreshing the table editable. Also patches the AEM overlay renderer to correctly position edit overlays on <tr> elements, which can get misplaced due to browser foster-parenting of table markup.

armaang1729 · 2026-05-19T10:14:38Z


+    /**
+     * Table row cells must not expose the standard Delete action (row/column flows handle structure).
+     * @param {Granite.author.Editable} editable


NOTE :

Table row cells must not expose the standard Delete action like normal components. The rows must be deleted through the delete row option added in the edit config of the table row.

adobe-bot · 2026-05-19T11:13:01Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2026-05-19T11:13:18Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-05-19T11:14:45Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-05-19T11:15:54Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

armaang1729 · 2026-05-20T05:36:25Z

@@ -0,0 +1,233 @@
+/*******************************************************************************


NOTE :

tableview.js — purpose

This file is the runtime view for the Adaptive Form Table component. It has three responsibilities:

Row insertion () — inserts a cloned <tr> into the correct <tbody> position using the row model's index. Handles three cases: empty tbody (append), index 0 (prepend before the first sibling), and mid-list (insert after the preceding sibling resolved by model index).

Hook attribute patching (#syncTableRowHooks) — FormView.Utils.updateId patches element id attributes on cloned nodes but does not touch data-cmp-hook-* attributes. Without this step, cloned add/remove buttons retain the template row's stale ID, causing every dynamically-added row to dispatch the wrong model index. This method re-stamps data-cmp-hook-add-instance and data-cmp-hook-remove-instance with the newly assigned model ID immediately after insertion.

min/maxOccur enforcement (#syncTableRowRepeatableControls) — after every addition or removal, walks every live row and sets data-cmp-visible on its add and remove buttons according to the instance manager's current item count vs. minOccur/maxOccur. A maxOccur of -1 means unbounded; minOccur of -1 means no floor.

armaang1729 · 2026-05-20T06:44:49Z

                handler="CQ.FormsCoreComponents.editorhooks.viewQualifiedName"
                icon="viewSOMExpression"
                text="View Qualified Name"/>
+        <addcolumn


NOTE :

Added addColumn and deleteColumn option in the text editconfig as the option to add column and delete will be displayed when the column cell is clicked which will be a text component so added a condition isCoreTableHeaderCell(editable) to display this option.

armaang1729 · 2026-05-20T09:47:31Z

+         * @returns {HTMLElement}
+         */
+        getRepeatableDomWrapper() {
+            const parent = this.element.parentElement;


NOTE :

This is the consumer of the virtual hook defined in FormPanel. The check for bemBlock on parentElement handles the edit-mode case where Sling wraps the <tr> in a <div class="cmp-adaptiveform-tablerow"> for the authoring overlay. In publish mode the <tr> has no such wrapper, so this.element (the <tr> itself) is returned directly. InstanceManager uses this for both cloning the template and tearing down removed rows.

armaang1729 · 2026-05-20T09:47:31Z

+         * @returns {HTMLElement}
+         */
+        getRepeatableInstancesContainerElement() {
+            const tableBody = this.element.closest(".cmp-adaptiveform-table__body") ||


NOTE :

Returns <tbody> as the container so InstanceManager.handleAddition inserts cloned rows into the right parent. Using closest handles both the semantic <tbody class="cmp-adaptiveform-table__body"> and any fallback structure, with parentElement as a last resort to stay consistent with the base class default.

armaang1729 · 2026-05-20T09:47:31Z

+         * @param {Object} label - The label state object.
+         */
+        updateLabel(label) {
+            // Table rows don't have visible labels, so this is a no-op


NOTE :

No-op intentionally — table rows have no visible label of their own (column headers are owned by tableheader). Without this override, applyState would call the base class updateLabel which would try to update a non-existent label DOM element.

armaang1729 · 2026-05-20T09:47:31Z

+         * @param {Object} state - The state to be applied.
+         */
+        applyState(state) {
+            this.updateVisible(state.visible);


NOTE :

Matches the FormPanel.applyState signature but explicitly skips anything table-row-irrelevant (e.g. updateLabel is a no-op here). Calling initializeHelpContent is kept because a row's visibility/enabled state still drives data-cmp-visible / data-cmp-enabled attributes that the rules engine reads.

armaang1729 · 2026-05-20T09:47:31Z

+    }
+
+    FormView.Utils.setupField(({element, formContainer}) => {
+        return new TableRow({element, formContainer})


NOTE :

Registers TableRow as the view for all elements matching [data-cmp-is="adaptiveFormTableRow"]. This is the standard FormView.Utils.setupField pattern — it both creates the view for elements already in the DOM and wires up the mutation observer so dynamically added rows (repeat add) are initialized automatically.

armaang1729 · 2026-05-20T09:47:31Z

-                    checkLabelText(textinputid11, panelid11, 'Text Input2', 'Panel2');
+                // find Panel[1]'s remove button by its model index
+                const removeBtn1 = Object.values(formContainer._fields).find(f =>
+                    f.getModel &&


NOTE :

Previous code used a hardcoded _fields array index to find the remove button, which broke after the instance removal logic was changed to id-based lookup (the field map order is no longer guaranteed to match insertion order). This change finds the remove button by inspecting the model — specifically the parent panel's index === 1 — making the test resilient to field map reordering.

armaang1729 · 2026-05-20T09:47:31Z

+                cy.get(`#${removeBtn1.getId()}`).find("button").click().then(() => {
+                    // after Panel[1] removed, find the surviving panel at index 1 by model
+                    const panel1remaining = Object.values(formContainer._fields).find(f =>
+                        f.getModel &&


NOTE :

After removal, the surviving panel at model index === 1 and its child text input are located dynamically rather than by a fixed _fields position. This is necessary because #removeChildInstance now splices by the live array index, which can shift the order of remaining entries in formContainer._fields.

adobe-bot · 2026-05-20T10:58:03Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2026-05-20T10:58:48Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2026-05-20T10:59:15Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-05-20T10:59:47Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-05-20T11:04:38Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2026-05-20T11:04:59Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

… table

…lspan in publish html

…lls merge feature

adobe-bot · 2026-06-15T09:20:55Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2026-06-15T09:20:56Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2026-06-15T09:22:20Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-06-15T09:23:25Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-06-16T10:01:59Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-06-16T10:02:28Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

armaang1729 added the work in progress label May 15, 2026

iamsudhanshu reviewed May 15, 2026

View reviewed changes

Comment thread .../main/content/jcr_root/apps/forms-components-examples/components/form/table/_cq_template.xml Outdated

armaang1729 commented May 19, 2026

View reviewed changes

github-actions Bot force-pushed the tableComponentFirstCheckIn branch from 552a08c to e878597 Compare May 19, 2026 10:37

armaang1729 commented May 20, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

armaang1729 commented May 20, 2026

View reviewed changes

armaang1729 force-pushed the tableComponentFirstCheckIn branch from e878597 to 90ced91 Compare May 20, 2026 10:21

github-actions Bot force-pushed the tableComponentFirstCheckIn branch from 90ced91 to 16d7af4 Compare May 20, 2026 10:21

armaang1729 force-pushed the tableComponentFirstCheckIn branch from 16d7af4 to 3db51ce Compare May 20, 2026 10:26

armaang1729 requested a review from devgurjar May 26, 2026 05:13

Armaan Gupta added 20 commits June 15, 2026 08:43

refactored the table.html

34811d0

updated README for the table Component

bde84da

Resolved Conflicts

73885d2

added sorting feature for the table component

aa80923

enabled sorting button during authoring too

8943627

added feature to disable/enable sorting on a particular column of the…

7ae0472

… table

added authoring options for sorting and column width

27d8616

added dor support for table component

34a709b

added dor testing

0b10178

added the feature of merge and split cell during runtime by adding co…

3a18898

…lspan in publish html

updated README for table, tableheader, tablerow

3345d7c

added the feature for merge row cells and commented out the header ce…

5aa26dd

…lls merge feature

added testing for second phase features

92e9463

fixed review comments 1

d83e9b1

fixed review comments 2

c284c02

fixed cypress tests

9a01916

fixed coverage

6bc6311

fixed the sorting behaviour to improve the archaic behavior

b78572c

fixed cypress testing mergesplit feature

da43f30

fixed cypress testing

02bb9c8

github-actions Bot force-pushed the tableComponentFirstCheckIn branch from 99f95f1 to 02bb9c8 Compare June 15, 2026 08:43

armaang1729 added in review and removed work in progress labels Jun 15, 2026

moved .css changes from core component to theme canvas

a259485

		@@ -0,0 +1,1108 @@
		/*******************************************************************************

		@@ -0,0 +1,233 @@
		/*******************************************************************************

Conversation

armaang1729 commented May 11, 2026

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

adobe-bot commented May 12, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented May 12, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented May 13, 2026

Accessibility Violations Found

Uh oh!

Uh oh!

codecov Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

armaang1729 May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adobe-bot commented May 19, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented May 19, 2026

Accessibility Violations Found

Uh oh!

armaang1729 May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armaang1729 May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adobe-bot commented May 19, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented May 19, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented May 19, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented May 19, 2026

Accessibility Violations Found

Uh oh!

armaang1729 May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armaang1729 May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

armaang1729 May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armaang1729 May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armaang1729 May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armaang1729 May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 19, 2026 •

edited

Loading

armaang1729 May 19, 2026 •

edited

Loading

armaang1729 May 19, 2026 •

edited

Loading

armaang1729 May 19, 2026 •

edited

Loading

armaang1729 May 20, 2026 •

edited

Loading

armaang1729 May 20, 2026 •

edited

Loading

armaang1729 May 20, 2026 •

edited

Loading

armaang1729 May 20, 2026 •

edited

Loading

armaang1729 May 20, 2026 •

edited

Loading

armaang1729 May 20, 2026 •

edited

Loading

armaang1729 May 20, 2026 •

edited

Loading

armaang1729 May 20, 2026 •

edited

Loading

armaang1729 May 20, 2026 •

edited

Loading