Fix/sites 44191 eds viewtype fieldtype#1889
Open
devgurjar wants to merge 2 commits into
Open
Conversation
…(SITES-44191) Adds hidden granite:hidden select fields for ./fd:viewType directly to component dialogs so the Content API's content-definition endpoint can surface EDS variant options without depending on include-stub expansion (SITES-43893). Changes: - panelcontainer: add fd:viewType select with accordion/modal/wizard options - textinput: add fd:viewType select with password option - numberinput: add fd:viewType select with range/rating options - termsandconditions: add missing fieldType select (panel) + fd:viewType select (tnc) Without these fields, all EDS components defaulted to field_type='panel' and variants sharing a resourceType (Range vs Number Input, Password vs Text Input, Panel vs Accordion/Modal/Wizard) were indistinguishable in the componentDefinitions response. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds hidden select fields for fieldType (file-input) and fd:viewType (signature) to the scribble component dialog so the Content API componentDefinitions endpoint surfaces the correct type metadata for EDS signature components. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Accessibility Violations Found
|
Accessibility Violations Found
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: