[FORMS-15359] Hide Read Only option in Single Checkbox v1 property dialog#1899
Draft
pankaj-parashar wants to merge 1 commit into
Draft
[FORMS-15359] Hide Read Only option in Single Checkbox v1 property dialog#1899pankaj-parashar wants to merge 1 commit into
pankaj-parashar wants to merge 1 commit into
Conversation
The Single Checkbox component does not support a read-only state, but the read-only checkbox was appearing in the property dialog via inheritance from the base component dialog. Add sling:hideResource overrides for the readonly and readonly-typehint nodes so they are suppressed from the merged dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkbox/v1/_cq_dialog/.content.xml), which was incorrectly surfaced since Read Only is not a valid property for a checkbox component.sling:hideResource=trueto thereadonlyandreadonly-typehintdialog nodes.Root Cause
The dialog inherited
readonlynodes from a parent definition, but the Read Only property does not apply to checkbox behaviour and should not be shown in the authoring UI.Test Plan
Jira
https://jira.corp.adobe.com/browse/FORMS-15359
🤖 Generated with Claude Code via OrcaFix skill