[FORMS-25355] Make checkedValue required in Checkbox v1 dialog to prevent silent 'on' submission#1901
Draft
pankaj-parashar wants to merge 1 commit into
Draft
[FORMS-25355] Make checkedValue required in Checkbox v1 dialog to prevent silent 'on' submission#1901pankaj-parashar wants to merge 1 commit into
pankaj-parashar wants to merge 1 commit into
Conversation
Authors could leave checkedValue blank, causing the HTML input to silently
submit "on" with no authoring-time warning. Mark the field as required so
the dialog cannot be saved without a value. The _cq_template.xml default
("on") pre-populates the field so authors are not blocked on new instances.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkbox/v1/_cq_dialog/.content.xml), preventing authors from leaving it blank.required="{Boolean}true"to thecheckedValuetextfield node.Root Cause
When the Checked Value field is left empty, the checkbox silently submits the string
"on"instead of the intended value. This is a hidden data quality issue — authors have no visual indication that leaving the field blank changes submission behaviour.Test Plan
Jira
https://jira.corp.adobe.com/browse/FORMS-25355
🤖 Generated with Claude Code via OrcaFix skill