feat(rule-utils): skip API call in registerCustomFunctionsV2 — always parse client-side#1905
Open
dmaurya929 wants to merge 3 commits into
Open
feat(rule-utils): skip API call in registerCustomFunctionsV2 — always parse client-side#1905dmaurya929 wants to merge 3 commits into
dmaurya929 wants to merge 3 commits into
Conversation
…parse client-side The servlet always returned clientSideParsingEnabled=true, making the HTTP round-trip to /adobe/forms/af/customfunctions/* redundant and adding 2-3s latency on large forms. extractFunctionNames() is now called directly without fetching funcConfig from the server. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tractFunctionNames Covers: no HTTP calls made, window functions registered, non-window names filtered, non-function window values filtered, empty form, form- level events/rules, nested panel items, and deduplication. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Accessibility Violations Found
|
…m functions The previous test waited for a GET to /customfunctionsprefix/* which no longer fires since registerCustomFunctionsV2 now always parses client-side. New test waits for AF_FormContainerInitialised then asserts the intercept alias has zero captured requests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
arunattri26
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/adobe/forms/af/customfunctions/*fromregisterCustomFunctionsV2inui.frontend/src/RuleUtils.jsclientSideParsingEnabled: true, so the call was unconditionally followed byextractFunctionNames(formJson)anyway — making it redundantextractFunctionNamesis now called directly; the window-filter andFunctionRuntime.registerFunctionslogic is unchangedTest plan
cd ui.frontend && npm test)ui.frontend/__tests__/RuleUtils.test.jscovers: no HTTP calls made, window functions registered, non-window names filtered, non-function window properties filtered, empty form, form-level events/rules, nested panel items, deduplication/adobe/forms/af/customfunctions/*🤖 Generated with Claude Code