FORMS-25008 add multiselect support for DropDown component#171
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
amit-mnnit
reviewed
Apr 16, 2026
| visible: state.label?.visible !== false | ||
| }, | ||
| isError: getValidationState(state) === 'invalid', | ||
| isMultiSelect: state.type === 'string[]', |
Collaborator
There was a problem hiding this comment.
It can be a number, boolean, or any other type. Don’t hardcode it as a string—just check whether the value contains '[]' or not.
Collaborator
Author
There was a problem hiding this comment.
Fixed. Changed to state.type?.includes('[]') so any array type (number[], boolean[], etc.) is correctly detected as multi-select, not just string[].
amit-mnnit
reviewed
Apr 16, 2026
| const dropValue = enumNames && enumNames.length ? enumNames : enums || []; | ||
| let selectedValue = value ?? ''; | ||
| const selectedValue = isMultiSelect | ||
| ? (Array.isArray(value) ? (value as any[]).map(String) : (value !== null && value !== undefined ? [String(value)] : [])) |
Collaborator
There was a problem hiding this comment.
Don’t hardcode it as a string
Collaborator
Author
There was a problem hiding this comment.
Fixed. Removed the String() coercions so values are passed in their original type. The as any[] cast was also removed since it was only needed to call .map().
amit-mnnit
requested changes
Apr 16, 2026
amit-mnnit
left a comment
amit-mnnit
left a comment
Collaborator
There was a problem hiding this comment.
Please check the comments
amit-mnnit
approved these changes
Apr 16, 2026
Collaborator
|
For this change there was already a PR raised #167 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multipleattribute to the<select>element inDropDown.tsxwhenisMultiSelectis truestring[]for multiselect dropdowns, dispatching an array instead of a single valuewithRuleEngine.tsxderivesisMultiSelectfromstate.type === 'string[]'isMultiSelect?: booleanto thePROPStype intype.tsxisFilledcheck updated to handle array values correctly for CSS class togglingJIRA
FORMS-25008