FORMS-25113 Sow multiselect options as scrollable visible list#173
Closed
gaurav5826 wants to merge 1 commit into
Closed
FORMS-25113 Sow multiselect options as scrollable visible list#173gaurav5826 wants to merge 1 commit into
gaurav5826 wants to merge 1 commit into
Conversation
Add size and style props to multiselect <select> in DropDown so options render as a visible scrollable list (capped at 6 rows) instead of a collapsed dropdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a dropdown was configured as multiselect (
type: string[]), the<select>element rendered with a fixed height of ~48px — just enough to show a single row — and was scrollable. This made it very difficult for users to see and pick from the available options.Solution
size={Math.min(options.length + 1, 6)}so the multiselect renders as an expanded visible list (capped at 6 rows to avoid taking up too much vertical space)style={{ height: 'auto' }}to override any fixed-height CSS that was collapsing the list back to 48pxSingle-select dropdowns are unaffected — both attributes are only applied when
isMultiSelectis true.Test plan
Fixes: FORMS-25113
Before:
After:
