Skip to content

fix: update stale setup test and rebuild dist - #243

Merged
shsteimer merged 2 commits into
mainfrom
fix/setup-test-codebasepath
Aug 27, 2026
Merged

shsteimer merged 2 commits into
mainfrom
fix/setup-test-codebasepath

Conversation

@shsteimer

Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR #205 changed codeBasePath derivation to import.meta.url but left one
assertion expecting the old DOM-based path.

Co-Authored-By: Sean Steimer <ssteimer@adobe.com>
dist/aem.js was stale relative to src changes in #205 and #242.

Co-Authored-By: Sean Steimer <ssteimer@adobe.com>
@shsteimer
shsteimer requested review from fkakatie and trieloff August 27, 2026 14:47
@shsteimer
shsteimer merged commit 34fb1f9 into main Aug 27, 2026
4 checks passed
@shsteimer
shsteimer deleted the fix/setup-test-codebasepath branch August 27, 2026 14:49
trieloff pushed a commit that referenced this pull request Aug 27, 2026
## [3.1.8](v3.1.7...v3.1.8) (2026-08-27)

### Bug Fixes

* derive codeBasePath from import.meta.url instead of DOM query ([#205](#205)) ([af0d5c2](af0d5c2))
* send RUM beacons to codeBasePath-relative /.rum instead of root ([#242](#242)) ([e9e4786](e9e4786))
* update stale setup test and rebuild dist ([#243](#243)) ([34fb1f9](34fb1f9)), closes [#205](#205) [#205](#205) [#242](#242)
@trieloff

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants