fix(ci): drop -- separator from changeset CLI invocations (v3 arg parsing) - #144
Merged
Merged
Conversation
@changesets/cli v3 switched its argument parser to cac, which no longer treats a leading -- as a no-op before the subcommand. With "changeset -- publish"/"changeset -- version", cac fails to resolve a subcommand and falls back to the interactive `add` flow, hanging the Publish workflow until it's cancelled by CI. Verified locally that "changeset -- publish" reproduces the interactive prompt while "changeset publish" resolves correctly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changesets/actionv2 input rename, but the Publish workflow onmainis now hanging/interactive instead of failing outright (run: https://github.com/adobe/aio-lib-telemetry/actions/runs/35333123591, cancelled after ~3 min by CI's own timeout).@changesets/cliv3 rewrote its argument parser to usecac(see its changelog: "Usecacfor CLI arg parsing and handling"). The workflow invokespnpm run changeset -- version/pnpm run changeset -- publish. With the old parser the leading--was a harmless no-op andpublish/versionstill resolved as the subcommand.cacdoesn't skip it the same way, so no subcommand resolves and the CLI falls back to its defaultaddcommand, which drops into the interactive "What kind of change is this?" prompt and hangs forever waiting for stdin.--—pnpm run <script> <args>doesn't require it.Test plan
pnpm run changeset -- publish --helpdrops into the interactiveaddprompt;pnpm run changeset publish --helpandpnpm run changeset version --helpboth resolve correctly and print their own helpmaincompletes without hanging