Per-listener ingress controller override

[azun]

Description

Add ingressController override for external listeners. This allows configuring and using different controllers than the cluster default.

Type of Change

• Bug Fix
• New Feature
• Breaking Change
• Refactor
• Documentation
• Other (please describe)

Checklist

• I have read the contributing guidelines
• Existing issues have been referenced (where applicable)
• I have verified this change is not present in other open pull requests
• Functionality is documented
• All code style checks pass
• New code contribution is covered by automated tests
• All new and existing tests pass

[dobrerazvan]

@azun I tested this PR and i found a bug what manifests when you change the fqdns it duplicates the resources:

 kubectl get httpproxies.projectcontour.io
NAME                  FQDN                  TLS SECRET                 STATUS   STATUS DESCRIPTION
b-0-kafka.dev.local   b-0-kafka.dev.local   projectcontour/envoycert   valid    Valid HTTPProxy
b-0-kafka.local.dev   b-0-kafka.local.dev   projectcontour/envoycert   valid    Valid HTTPProxy
b-1-kafka.dev.local   b-1-kafka.dev.local   projectcontour/envoycert   valid    Valid HTTPProxy
b-1-kafka.local.dev   b-1-kafka.local.dev   projectcontour/envoycert   valid    Valid HTTPProxy
b-2-kafka.dev.local   b-2-kafka.dev.local   projectcontour/envoycert   valid    Valid HTTPProxy
b-2-kafka.local.dev   b-2-kafka.local.dev   projectcontour/envoycert   valid    Valid HTTPProxy
kafka.local.dev       kafka.local.dev       projectcontour/envoycert   valid    Valid HTTPProxy

Same for the shared httpproxy (kafka.local.dev), i just deleted the other one.

I was using the ingress manifest:

externalListeners:
      - accessMethod: ClusterIP
        ingressController: "contour"
        anyCastPort: 443
        config:
          defaultIngressConfig: ""
          ingressConfig:
            external:
              contourIngressConfig:
                brokerFQDNTemplate: b-%id-kafka.local.dev
                tlsSecretName: projectcontour/envoycert
              hostnameOverride: kafka.local.dev
        containerPort: 29095
        externalStartingPort: -1
        name: external
        type: plaintext
        usedForInnerBrokerCommunication: false

[dobrerazvan]

@azun I tested this PR and i found a bug what manifests when you change the fqdns it duplicates the resources:

 kubectl get httpproxies.projectcontour.io
NAME                  FQDN                  TLS SECRET                 STATUS   STATUS DESCRIPTION
b-0-kafka.dev.local   b-0-kafka.dev.local   projectcontour/envoycert   valid    Valid HTTPProxy
b-0-kafka.local.dev   b-0-kafka.local.dev   projectcontour/envoycert   valid    Valid HTTPProxy
b-1-kafka.dev.local   b-1-kafka.dev.local   projectcontour/envoycert   valid    Valid HTTPProxy
b-1-kafka.local.dev   b-1-kafka.local.dev   projectcontour/envoycert   valid    Valid HTTPProxy
b-2-kafka.dev.local   b-2-kafka.dev.local   projectcontour/envoycert   valid    Valid HTTPProxy
b-2-kafka.local.dev   b-2-kafka.local.dev   projectcontour/envoycert   valid    Valid HTTPProxy
kafka.local.dev       kafka.local.dev       projectcontour/envoycert   valid    Valid HTTPProxy

Same for the shared httpproxy (kafka.local.dev), i just deleted the other one.

I was using the ingress manifest:

externalListeners:
      - accessMethod: ClusterIP
        ingressController: "contour"
        anyCastPort: 443
        config:
          defaultIngressConfig: ""
          ingressConfig:
            external:
              contourIngressConfig:
                brokerFQDNTemplate: b-%id-kafka.local.dev
                tlsSecretName: projectcontour/envoycert
              hostnameOverride: kafka.local.dev
        containerPort: 29095
        externalStartingPort: -1
        name: external
        type: plaintext
        usedForInnerBrokerCommunication: false

Indeed setting removeUnusedIngressResources removes the prev httpproxy resources:

kubectl get httpproxies.projectcontour.io
NAME                  FQDN                  TLS SECRET                 STATUS   STATUS DESCRIPTION
c-0-kafka.local.dev   c-0-kafka.local.dev   projectcontour/envoycert   valid    Valid HTTPProxy
c-1-kafka.local.dev   c-1-kafka.local.dev   projectcontour/envoycert   valid    Valid HTTPProxy
c-2-kafka.local.dev   c-2-kafka.local.dev   projectcontour/envoycert   valid    Valid HTTPProxy
kafka.local.dev       kafka.local.dev       projectcontour/envoycert   valid    Valid HTTPProxy

Not a bug