Repository navigation
perf(s2): compute hover deemphasis opacity once per series - #1002
Merged
Merged
Conversation
…tionData Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
c-lamoureux
marked this pull request as ready for review
October 9, 2026 22:10
|
Contributor
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-1002/ 🎨 S2 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-1002-s2/ 🎨 S2 Dev Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-1002-s2-dev/ 📚 Docs -> https://opensource.adobe.com/react-spectrum-charts/PR-1002-docs/ |
madelineluke
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
hoverFractionDatagets adeemphasisOpacityformula field, so each series' faded opacity is computed once per animation row instead of once per data point.hoverFraction(..., 'deemphasisOpacity');hoverFractiongains an optionalfieldargument (defaults tofraction).FADE_FACTOR + (1 - FADE_FACTOR) * ramp(fraction)expression, moved into the data.Why
With the CSP-safe interpreter, every vertex evaluated the full ramp expression on each hover animation frame. Moving it to one row per series removes that per-vertex math.
Perf
Testing
hoverFractionfieldargument, and updated line, bar and point opacity expectations.