fix(react-stately): enable useControlledState early effect in React Native

[su-jin1425]

Description

Closes #10512

Summary

useControlledState uses an early synchronous effect to keep its internal value ref synchronized with controlled prop changes. The effect was previously enabled only when document was defined.

In React Native, document is not available, causing the early effect to become a no-op. As a result, parent-driven controlled value changes could be ignored.

Based on maintainer feedback, this PR introduces a specific check for React Native using navigator.product === 'ReactNative'. This ensures the synchronous effect runs in both standard DOM environments and React Native, without using window which would break Deno support.

Changes

• Updated the environment check in useControlledState.ts to use typeof document !== 'undefined' || isReactNative.
• Removed the previous JS-DOM regression test, as it did not properly simulate the non-DOM environment condition and was deemed unnecessary.

Why

React Native does not provide document, so the previous check incorrectly disabled the synchronization effect. Checking for isReactNative explicitly avoids regressions in other DOM-less environments like Deno.

Pull Request Checklist

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (N/A).
• Filled out test instructions.
• Updated documentation (N/A).
• Looked at the Accessibility Practices for this feature (N/A).
• I understand every change in this PR and can explain why it's there.
• If AI-assisted, I followed our AI contribution guidance and pointed my assistant at CLAUDE.md.

[su-jin1425]

In Short just changed document to window and added Regression test

[snowystinger]

what does this test have to do with anything?

[snowystinger]

you didn't answer this question. Please see https://github.com/adobe/react-spectrum/blob/main/CONTRIBUTING.md#ai-assisted-contributions

[su-jin1425]

its a additional regression test i thought it was useful, but now i saw the added test does not directly exercise the document vs window environment condition that causes the React Native bug, so it does not provide meaningful regression coverage for this change.

[snowystinger]

if I recall correctly, detecting SSR is best to check that document !== undefined and the check against window will fail against Deno

There's a check for React Native we could possibly add to this check

const isReactNative = typeof navigator !== 'undefined' && navigator.product === 'ReactNative';

typeof document !== 'undefined' || isReactNative

What do you think?

[snowystinger]

what was your opinion on this question?

[su-jin1425]

The document check preserves existing SSR behavior, while the React Native check targets the actual issue. The tradeoff is relying on navigator.product, but this avoids changing behavior for runtimes like Deno. I think this is the safer, more targeted approach.

[su-jin1425]

@snowystinger I have chnages as per your request , rereview once again and tell if you need any more changes.

[su-jin1425]

@snowystinger I think I still need more time to investigate so i will tell you when to review

And also tell me that am I in correct approach or not.

[su-jin1425]

@snowystinger I'm Ready for Rereview

[snowystinger]

Thanks, I think this is ok. Wish we had a place to test against React Native for stately.

[LFDanLu]

instead of checking for this, we can use a check for versions below React 19 since this was to avoid a warning that occurs in those older versions

[snowystinger]

No need to request review every time, it's a lot of added noise. Team members will get to this when they can. Thanks.

[su-jin1425]

Ok.