feat: rework scroll utilities and fix layout bugs - #10556
Open
nwidynski wants to merge 2 commits into
Open
Conversation
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes no issues directly, because this PR is intentionally limited to additions only. Migrating call sites to the new utilities and signatures is to be done in chore follow-ups, because it would otherwise be rather hard to review what changed here.
From a high level, this is the first round of changes for a set of layout- and drastically improved scroll utilities. Here is what this PR does today:
1.) Fix issues in
getScrollParentandgetScrollParentsby merging their implementation into a new generator2.) Fix various bugs in
isScrollableand expand its scope for window scrolling3.) Introduce modalities and axis isolation into scroll utilities (
pointer-> skip hidden,virtual-> incl. hidden)The rest is just chores of moving code blocks from
calculatePositionanddomHelpers.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: