Skip to content

fix: support aria-current in LinkContext #10573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-pledge-io wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −3
Open

fix: support aria-current in LinkContext #10573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0afc64
fix: add support for 'aria-current' prop in Link component
Sep 4, 2026
f3fa415
fix: update 'aria-current' prop handling in Breadcrumb component
Sep 4, 2026
1933550
fix: ensure 'aria-current' prop is correctly typed in NavigationTreeI…
Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-aria-components/src/Breadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export const Breadcrumb = /*#__PURE__*/ createLeafComponent(
let isCurrent = node.nextKey == null;
let {isDisabled, onAction} = useSlottedContext(BreadcrumbsContext)!;
let linkProps = {
'aria-current': isCurrent ? 'page' : null,
'aria-current': isCurrent ? ('page' as const) : undefined,
isDisabled: isDisabled || isCurrent,
onPress: () => onAction?.(node.key)
};
Expand Down
2 changes: 1 addition & 1 deletion packages/react-aria-components/src/NavigationTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ function NavigationTreeItemContentInner(props: NavigationTreeItemContentInnerPro
// Provide onFocusChange so the link reports its focus up to NavigationTreeItem.
let linkContextValue = {
...linkProps,
'aria-current': isCurrent ? 'page' : undefined,
'aria-current': isCurrent ? ('page' as const) : undefined,
onFocusChange: setLinkFocused,
onPress: linkProps.href == null && hasChildItems ? () => state.toggleKey(id) : undefined
};
Expand Down
6 changes: 6 additions & 0 deletions packages/react-aria-components/test/Link.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ describe('Link', () => {
expect(link).toHaveAttribute('id', 'my-link-id');
});

it('should support accessibility props', () => {
let {getByRole} = render(<Link aria-current="page">Test</Link>);
let link = getByRole('link');
expect(link).toHaveAttribute('aria-current', 'page');
});

it('should support render props', async () => {
let {getByRole} = render(<Link>{({isHovered}) => (isHovered ? 'Hovered' : 'Test')}</Link>);
let link = getByRole('link');
Expand Down
8 changes: 7 additions & 1 deletion packages/react-aria/src/link/useLink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ import {usePress} from '../interactions/usePress';

export interface LinkProps extends PressEvents, FocusableProps {}

export interface AriaLinkProps extends LinkProps, LinkDOMProps, AriaLabelingProps {}
export interface AriaLinkProps extends LinkProps, LinkDOMProps, AriaLabelingProps {
/**
* Indicates whether this element represents the current item within a container or set of related
* elements.
*/
'aria-current'?: boolean | 'true' | 'false' | 'page' | 'step' | 'location' | 'date' | 'time';
}

export interface AriaLinkOptions extends AriaLinkProps {
/** Whether the link is disabled. */
Expand Down