Skip to content

docs: don't animate pixel loader when not in view #10576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yihuiliao wants to merge 8 commits into
base: main
Choose a base branch
from
+25 −8
Open

docs: don't animate pixel loader when not in view #10576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b1807a6
chore: don't animate pixel loader when not in view in docs
yihuiliao Sep 4, 2026
dde84bf
update render
yihuiliao Sep 4, 2026
1232a45
formatting
yihuiliao Sep 4, 2026
51c5800
fix typecheck
yihuiliao Sep 4, 2026
9688604
fix typecheck fr
yihuiliao Sep 4, 2026
67add4c
add intersection observer to pixel loader instead
yihuiliao Sep 4, 2026
891c8e1
small docs stuff
yihuiliao Sep 4, 2026
1f84d8d
Apply suggestion from @yihuiliao
yihuiliao Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions packages/@react-spectrum/ai/src/loader/react.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,19 @@ export function PixelLoader(props: PixelLoaderProps) {
} = props;
let isReducedMotion = useReducedMotion();

let ref = React.useRef<HTMLDivElement>(null);
let [isInView, setIsInView] = React.useState(false);

React.useEffect(() => {
if (!ref.current) {
return;
}

let observer = new IntersectionObserver(([entry]) => setIsInView(entry.isIntersecting));
observer.observe(ref.current);
return () => observer.disconnect();
}, []);

// Normalize to a sequence.
const sequence = React.useMemo(
() => (Array.isArray(icon[0]) ? icon : [icon]) as Cell[][],
Expand All @@ -284,13 +297,14 @@ export function PixelLoader(props: PixelLoaderProps) {

// Advance the sequence one icon per cycle while playing. Single-icon
// loaders never start a timer — they're a pure infinite CSS loop.
let isAdvancing = isPlaying && isInView;
React.useEffect(() => {
if (!isPlaying || !isSequence) {
if (!isAdvancing || !isSequence) {
return undefined;
}
const id = setInterval(() => setTick(t => t + 1), duration);
return () => clearInterval(id);
}, [isPlaying, isSequence, duration, sequence]);
}, [isAdvancing, isSequence, duration, sequence]);

const animId = iconId(cells);
const css = keyframesFor(cells, isReducedMotion);
Expand All @@ -314,6 +328,7 @@ export function PixelLoader(props: PixelLoaderProps) {

return (
<div
ref={ref}
aria-hidden="true"
className={className}
style={{
Expand All @@ -326,7 +341,7 @@ export function PixelLoader(props: PixelLoaderProps) {
forcedColorAdjust: 'none',
willChange: 'opacity',
...(isPlaying && {
animation: `${animId}-group-o ${duration}ms linear ${iteration}`
animation: `${animId}-group-o ${duration}ms linear ${iteration} ${isInView ? 'running' : 'paused'}`
})
}}
{...rest}>
Expand Down Expand Up @@ -368,8 +383,8 @@ export function PixelLoader(props: PixelLoaderProps) {
...(isPlaying &&
!isReducedMotion && {
animation:
`${animId}-${i}-y ${duration}ms linear ${iteration}, ` +
`${animId}-${i}-s ${duration}ms linear ${iteration}`,
`${animId}-${i}-y ${duration}ms linear ${iteration} ${isInView ? 'running' : 'paused'}, ` +
`${animId}-${i}-s ${duration}ms linear ${iteration} ${isInView ? 'running' : 'paused'}`,
willChange: 'transform'
})
}}
Expand Down
8 changes: 5 additions & 3 deletions packages/dev/s2-docs/pages/s2/ai-components.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,19 +588,21 @@ import {style} from '@react-spectrum/s2/style' with {type: 'macro'};

function PresetLoader(props) {
return (
<div className={style({height: 40})}>
<div className={style({height: 40})} >
{/*- begin highlight -*/}
<PixelLoader
{...props}
/* PROPS */
/>
{/*- end highlight -*/}
</div>
)
);
}
```

### Usage

Use the `pixelLoader` prop on `PromptTokenField` and `ResponseStatusTitle` to display the pixel loader.
Use the `pixelLoader` prop on `ResponseStatusTitle` and `PromptTokenField` to display the pixel loader.

<ExampleSwitcher type={null} examples={['ResponseStatus', 'PromptField']}>

Expand Down