Skip to content

docs: Prefetch in-viewport links #9294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devongovett wants to merge 9 commits into
base: main
Choose a base branch
from
+1,192 −1,149
Open

docs: Prefetch in-viewport links #9294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d16e6b2
Pre-fetch links in viewport
devongovett Dec 6, 2025
ae51442
Smaller RSC payload for types in development
devongovett Dec 6, 2025
75fe57d
Wait for double collection render to read ref
devongovett Dec 6, 2025
6c49b6c
Merge style macro CSS from s2 pages into main CSS bundle
devongovett Dec 6, 2025
7b87184
Don't include style macro type docs on every page
devongovett Dec 6, 2025
0fac481
Upgrade parcel to v2.16.3
devongovett Dec 6, 2025
c24f02a
Merge branch 'main' of github.com:adobe/react-spectrum into prefetch-…
devongovett Dec 9, 2025
912bff2
Merge branch 'main' of github.com:adobe/react-spectrum into prefetch-…
devongovett Dec 10, 2025
1306476
fix build
devongovett Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions .yarn/patches/@parcel-packager-react-static-npm-2.16.1-138e4b8f05.patch
View file
Open in desktop

This file was deleted.

37 changes: 19 additions & 18 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,22 +89,22 @@
"@faker-js/faker": "^8.4.1",
"@jdb8/eslint-plugin-monorepo": "^1.0.1",
"@octokit/rest": "*",
"@parcel/bundler-library": "^2.16.1",
"@parcel/config-default": "^2.16.1",
"@parcel/bundler-library": "^2.16.3",
"@parcel/config-default": "^2.16.3",
"@parcel/config-storybook": "^0.0.2",
"@parcel/core": "^2.16.1",
"@parcel/optimizer-data-url": "^2.16.1",
"@parcel/optimizer-terser": "^2.16.1",
"@parcel/packager-react-static": "patch:@parcel/packager-react-static@npm%3A2.16.1#~/.yarn/patches/@parcel-packager-react-static-npm-2.16.1-138e4b8f05.patch",
"@parcel/packager-ts": "^2.16.1",
"@parcel/reporter-bundle-analyzer": "^2.16.1",
"@parcel/reporter-cli": "^2.16.1",
"@parcel/resolver-glob": "^2.16.1",
"@parcel/transformer-inline": "^2.16.1",
"@parcel/transformer-inline-string": "^2.16.1",
"@parcel/transformer-react-static": "^2.16.1",
"@parcel/transformer-svg-react": "^2.16.1",
"@parcel/transformer-typescript-types": "^2.16.1",
"@parcel/core": "^2.16.3",
"@parcel/optimizer-data-url": "^2.16.3",
"@parcel/optimizer-terser": "^2.16.3",
"@parcel/packager-react-static": "^2.16.3",
"@parcel/packager-ts": "^2.16.3",
"@parcel/reporter-bundle-analyzer": "^2.16.3",
"@parcel/reporter-cli": "^2.16.3",
"@parcel/resolver-glob": "^2.16.3",
"@parcel/transformer-inline": "^2.16.3",
"@parcel/transformer-inline-string": "^2.16.3",
"@parcel/transformer-react-static": "^2.16.3",
"@parcel/transformer-svg-react": "^2.16.3",
"@parcel/transformer-typescript-types": "^2.16.3",
"@react-spectrum/parcel-namer-s2": "^0.3.0",
"@react-spectrum/s2-icon-builder": "^0.3.0",
"@spectrum-css/component-builder": "workspace:^",
Expand Down Expand Up @@ -171,7 +171,7 @@
"md5": "^2.2.1",
"motion": "^12.23.6",
"npm-cli-login": "^1.0.0",
"parcel": "^2.16.1",
"parcel": "^2.16.3",
"parcel-optimizer-strict-mode": "workspace:^",
"patch-package": "^6.2.0",
"playwright": "^1.45.3",
Expand Down Expand Up @@ -233,7 +233,7 @@
"lightningcss": "1.30.1",
"react-server-dom-parcel": "canary",
"react-test-renderer": "19.1.0",
"@parcel/packager-react-static": "patch:@parcel/packager-react-static@npm%3A2.16.1#~/.yarn/patches/@parcel-packager-react-static-npm-2.16.1-138e4b8f05.patch"
"@parcel/packager-react-static": "^2.16.3"
},
"@parcel/transformer-css": {
"cssModules": {
Expand Down Expand Up @@ -269,7 +269,8 @@
"name": "s2-styles",
"assets": [
"packages/@react-spectrum/s2/**",
"packages/dev/s2-docs/src/**"
"packages/dev/s2-docs/src/**",
"packages/dev/s2-docs/pages/s2/**/*.{mdx,tsx,ts,js}"
],
"types": [
"css"
Expand Down
2 changes: 1 addition & 1 deletion packages/@react-spectrum/s2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
"dependencies": {
"@internationalized/date": "^3.10.0",
"@internationalized/number": "^3.6.5",
"@parcel/macros": "^2.16.1",
"@parcel/macros": "^2.16.3",
"@react-aria/calendar": "^3.9.2",
"@react-aria/collections": "^3.0.0",
"@react-aria/focus": "^3.21.2",
Expand Down
8 changes: 4 additions & 4 deletions packages/dev/parcel-config-storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
"access": "public"
},
"dependencies": {
"@parcel/config-default": "^2.16.1",
"@parcel/core": "^2.16.1",
"@parcel/config-default": "^2.16.3",
"@parcel/core": "^2.16.3",
"@parcel/resolver-storybook": "^0.0.0",
"@parcel/transformer-js": "^2.16.1",
"@parcel/transformer-react-refresh-wrap": "^2.16.1",
"@parcel/transformer-js": "^2.16.3",
"@parcel/transformer-react-refresh-wrap": "^2.16.3",
"@parcel/transformer-storybook": "^0.0.2"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/parcel-namer-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"parcel": "^2.0.0"
},
"dependencies": {
"@parcel/plugin": "^2.16.1"
"@parcel/plugin": "^2.16.3"
}
}
2 changes: 1 addition & 1 deletion packages/dev/parcel-namer-intl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"parcel": "^2.0.0"
},
"dependencies": {
"@parcel/plugin": "^2.16.1"
"@parcel/plugin": "^2.16.3"
}
}
2 changes: 1 addition & 1 deletion packages/dev/parcel-namer-s2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"parcel": "^2.0.0"
},
"dependencies": {
"@parcel/plugin": "^2.16.1"
"@parcel/plugin": "^2.16.3"
},
"rsp": {
"type": "cli"
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/parcel-optimizer-strict-mode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"parcel": "^2.0.0"
},
"dependencies": {
"@parcel/plugin": "^2.16.1"
"@parcel/plugin": "^2.16.3"
}
}
2 changes: 1 addition & 1 deletion packages/dev/parcel-packager-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"parcel": "^2.0.0"
},
"dependencies": {
"@parcel/plugin": "^2.16.1"
"@parcel/plugin": "^2.16.3"
}
}
4 changes: 2 additions & 2 deletions packages/dev/parcel-packager-ssg/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"parcel": "^2.0.0"
},
"dependencies": {
"@parcel/plugin": "^2.16.1",
"@parcel/utils": "^2.16.1"
"@parcel/plugin": "^2.16.3",
"@parcel/utils": "^2.16.3"
},
"peerDependencies": {
"react": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0-rc.1",
Expand Down
6 changes: 3 additions & 3 deletions packages/dev/parcel-resolver-build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"parcel": "^2.0.0"
},
"dependencies": {
"@parcel/core": "^2.16.1",
"@parcel/node-resolver-core": "^3.7.1",
"@parcel/plugin": "^2.16.1"
"@parcel/core": "^2.16.3",
"@parcel/node-resolver-core": "^3.7.3",
"@parcel/plugin": "^2.16.3"
}
}
6 changes: 3 additions & 3 deletions packages/dev/parcel-resolver-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"parcel": "^2.0.0"
},
"dependencies": {
"@parcel/core": "^2.16.1",
"@parcel/node-resolver-core": "^3.7.1",
"@parcel/plugin": "^2.16.1"
"@parcel/core": "^2.16.3",
"@parcel/node-resolver-core": "^3.7.3",
"@parcel/plugin": "^2.16.3"
}
}
8 changes: 4 additions & 4 deletions packages/dev/parcel-resolver-storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
"parcel": "^2.8.0"
},
"dependencies": {
"@parcel/core": "^2.16.1",
"@parcel/node-resolver-core": "^3.7.1",
"@parcel/plugin": "^2.16.1",
"@parcel/utils": "^2.16.1"
"@parcel/core": "^2.16.3",
"@parcel/node-resolver-core": "^3.7.3",
"@parcel/plugin": "^2.16.3",
"@parcel/utils": "^2.16.3"
},
"scripts": {
"build": "rm -rf dist && swc . -d dist --config-file ../../.swcrc",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/parcel-transformer-css-env/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"parcel": "^2.0.0"
},
"dependencies": {
"@parcel/plugin": "^2.16.1"
"@parcel/plugin": "^2.16.3"
}
}
6 changes: 3 additions & 3 deletions packages/dev/parcel-transformer-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
"@babel/parser": "^7.24.0",
"@babel/traverse": "^7.24.0",
"@babel/types": "^7.24.0",
"@parcel/plugin": "^2.16.1",
"@parcel/plugin": "^2.16.3",
"doctrine": "^3.0.0"
},
"devDependencies": {
"@parcel/core": "^2.16.1",
"@parcel/fs": "^2.16.1"
"@parcel/core": "^2.16.3",
"@parcel/fs": "^2.16.3"
}
}
2 changes: 1 addition & 1 deletion packages/dev/parcel-transformer-intl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
},
"dependencies": {
"@internationalized/string-compiler": "^3.0.0",
"@parcel/plugin": "^2.16.1"
"@parcel/plugin": "^2.16.3"
}
}
4 changes: 2 additions & 2 deletions packages/dev/parcel-transformer-mdx-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"dependencies": {
"@mdx-js/mdx": "next",
"@mdx-js/react": "next",
"@parcel/core": "^2.16.1",
"@parcel/plugin": "^2.16.1",
"@parcel/core": "^2.16.3",
"@parcel/plugin": "^2.16.3",
"dprint-node": "^1.0.7",
"js-yaml": "^3.13.1",
"mdast-util-toc": "^6.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/parcel-transformer-mdx-extract/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"parcel": "^2.12.0"
},
"dependencies": {
"@parcel/plugin": "^2.16.1",
"@parcel/plugin": "^2.16.3",
"remark-mdx": "^2.0.0-rc.2",
"remark-parse": "^10.0.1",
"unified": "^10.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/parcel-transformer-mdx-storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"dependencies": {
"@mdx-js/mdx": "next",
"@mdx-js/react": "next",
"@parcel/plugin": "^2.16.1"
"@parcel/plugin": "^2.16.3"
},
"peerDependencies": {
"react": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0-rc.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/parcel-transformer-storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"dependencies": {
"@babel/parser": "^7.23.0",
"@babel/types": "^7.23.0",
"@parcel/plugin": "^2.16.1",
"@parcel/plugin": "^2.16.3",
"@parcel/source-map": "^2.1.1",
"@storybook/csf-tools": "^8",
"@storybook/docs-tools": "^8",
Expand Down
4 changes: 2 additions & 2 deletions packages/dev/s2-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
},
"dependencies": {
"@babel/parser": "^7.26.3",
"@parcel/plugin": "^2.16.1",
"@parcel/rsc": "^2.16.1",
"@parcel/plugin": "^2.16.3",
"@parcel/rsc": "^2.16.3",
"@react-aria/focus": "^3.20.4",
"@react-aria/i18n": "^3.12.10",
"@react-aria/interactions": "^3.25.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/s2-docs/pages/s2/style-macro.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {Layout} from '../../src/Layout';
import {InlineAlert, Heading, Content, Link} from '@react-spectrum/s2';
import {StyleMacroProperties} from '../../src/types';
import {StyleMacroProperties} from '../../src/StyleMacroProperties';
import {getPropertyDefinitions, getShorthandDefinitions} from '../../src/styleProperties';
export default Layout;

Expand Down
20 changes: 10 additions & 10 deletions packages/dev/s2-docs/src/ComponentCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import BreadcrumbsSvg from '@react-spectrum/docs/pages/assets/component-illustra
import ButtonGroupSvg from '@react-spectrum/docs/pages/assets/component-illustrations/ButtonGroup.svg';
import ButtonSvg from '@react-spectrum/docs/pages/assets/component-illustrations/Button.svg';
import CalendarSvg from '@react-spectrum/docs/pages/assets/component-illustrations/Calendar.svg';
import {Card, CardPreview, CardProps, Content, Text} from '@react-spectrum/s2';
import {CardProps} from '@react-spectrum/s2';
import CardSvg from '@react-spectrum/docs/pages/assets/component-illustrations/Card.svg';
import CardViewSvg from '@react-spectrum/docs/pages/assets/component-illustrations/CardView.svg';
import CheckboxGroupSvg from '@react-spectrum/docs/pages/assets/component-illustrations/CheckboxGroup.svg';
Expand All @@ -26,6 +26,7 @@ import ColorSwatchPickerSvg from '@react-spectrum/docs/pages/assets/component-il
import ColorSwatchSvg from '@react-spectrum/docs/pages/assets/component-illustrations/ColorSwatch.svg';
import ColorWheelSvg from '@react-spectrum/docs/pages/assets/component-illustrations/ColorWheel.svg';
import ComboBoxSvg from '@react-spectrum/docs/pages/assets/component-illustrations/ComboBox.svg';
import {ComponentCardClient} from './ComponentCardClient';
import ContextualHelpSvg from '@react-spectrum/docs/pages/assets/component-illustrations/ContextualHelp.svg';
import DateFieldSvg from '@react-spectrum/docs/pages/assets/component-illustrations/DateField.svg';
import DatePickerSvg from '@react-spectrum/docs/pages/assets/component-illustrations/DatePicker.svg';
Expand Down Expand Up @@ -310,15 +311,14 @@ export function ComponentCard({id, name, href, description, size, ...otherProps}
}

return (
<Card {...otherProps} id={id} href={href} size={size} textValue={name}>
<CardPreview>
{preview}
</CardPreview>
<Content>
<Text slot="title">{name}</Text>
{description && <Text slot="description">{description}</Text>}
</Content>
</Card>
<ComponentCardClient
{...otherProps}
id={id}
href={href}
size={size}
name={name}
description={description}
preview={preview} />
);
}

Expand Down
39 changes: 39 additions & 0 deletions packages/dev/s2-docs/src/ComponentCardClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
'use client';
import {Card, CardPreview, CardProps, Content, Text} from '@react-spectrum/s2';
import {ReactNode, useEffect, useRef} from 'react';
import {registerSpectrumLink} from './prefetch';

interface ComponentCardProps extends Omit<CardProps, 'children'> {
preview: ReactNode,
name: string,
description?: string
}

export function ComponentCardClient(props: ComponentCardProps) {
let {preview, name, description, href, ...otherProps} = props;
let ref = useRef(null);
useEffect(() => {
// Wait for double collection render.
let res;
let frame = requestAnimationFrame(() => {
res = registerSpectrumLink(ref.current);
});

return () => {
cancelAnimationFrame(frame);
res?.();
};
}, []);

return (
<Card {...otherProps} href={href} textValue={name} ref={ref}>
<CardPreview>
{preview}
</CardPreview>
<Content>
<Text slot="title">{name}</Text>
{description && <Text slot="description">{description}</Text>}
</Content>
</Card>
);
}
Loading