feat: update onboarding flow to align with audit-worker config-free execution #2541
feat: update onboarding flow to align with audit-worker config-free execution #2541tkotthakota-adobe wants to merge 4 commits into
Conversation
|
This PR will trigger no release when merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tathagat2241
left a comment
There was a problem hiding this comment.
Issues
Bug — Dead code in else if (scheduledRun) (Critical)
File: src/support/utils.js, around line 1814
// Before
} else {
log.debug(All the required audits...);
}
// After
} else if (scheduledRun) { // ← always false here
log.debug(All the required audits...);
}
This block is unreachable. We're in the else branch of if (scheduledRun), so scheduledRun is guaranteed to be false — the else if (scheduledRun) condition can never be true. The debug log will never fire.
Intent is unclear — was the goal to remove the log entirely, or to replace it with a different message for the non-scheduled case? Either way, else if (scheduledRun) here is logically impossible and should be resolved.
https://jira.corp.adobe.com/browse/SITES-45860
Following the recent audit-worker change that allows audits to run regardless of configuration state, the onboarding flow no longer needs to enable audits in the global configuration before triggering them.