Skip to content

docs(color-handle): add Phase 1 migration plan#6414

Open
blunteshwar wants to merge 5 commits into
mainfrom
color-handle-migration-plan
Open

docs(color-handle): add Phase 1 migration plan#6414
blunteshwar wants to merge 5 commits into
mainfrom
color-handle-migration-plan

Conversation

@blunteshwar

@blunteshwar blunteshwar commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the Phase 1 (Preparation) 1st-gen → 2nd-gen migration plan for color-handle at CONTRIBUTOR-DOCS/03_project-planning/03_components/color-handle/migration-plan.md. Planning output only — no component code changes. Also includes the auto-regenerated CONTRIBUTOR-DOCS navigation (breadcrumbs/TOC) for the new file.

Motivation and context

color-handle is queued for 2nd-gen migration. Its dependencies are already migrated (color-loupe; opacity-checkerboard as a shared stylesheet), so it is unblocked. This plan documents the 1st-gen surface, breaking changes, the core/SWC split architecture, and the new accessibility work from SWC-2295.

Confirmed decisions

  • core/SWC split (ColorHandleBase in core, swc-color-handle in SWC), mirroring the migrated color-loupe.
  • Color loupe stays built-in (composed internally), not slotted.
  • New a11y (SWC-2295): adaptive white-first dual-border for ≥3:1 non-text contrast (WCAG 1.4.11) + grow-on-focus/press as the focus indicator (no separate ring). Property names (color/open/focused/disabled) unchanged. Supersedes the prior SWC-1134 exception.

Related issue(s)

  • a11y driver: SWC-2295
  • Epic: SWC-#### (pending)

Reviewer notes

This is a plan for review, not implementation. Open questions are tracked in the plan's Blockers section:

  • Q1 Figma S2 / Web (Desktop scale) reference missing
  • Q2 no color-handle rendering-and-styling analysis yet
  • Q3 keep focused public/reflected vs internal-only
  • Q4 no color-handle accessibility-migration-analysis yet (SWC-2295 references it)
  • Q5 Epic number

Accessibility testing checklist

N/A for this PR — documentation/planning only, no runnable component changes. The plan itself defines the a11y requirements (WCAG 1.4.11 non-text contrast) to be implemented and tested in later phases.

Add the 1st-gen to 2nd-gen migration plan for color-handle, covering API
surface, dependencies, breaking changes, core/SWC split architecture, and
the SWC-2295 adaptive white-first border contrast (WCAG 1.4.11) a11y work.

Confirmed decisions: core/SWC split mirroring color-loupe, color-loupe kept
built-in (not slotted), and grow-on-focus as the focus indicator.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@blunteshwar blunteshwar requested a review from a team as a code owner June 17, 2026 06:21
@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c1760b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6414

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

blunteshwar and others added 2 commits June 17, 2026 15:17
Update the color-handle migration plan after reviewing the Figma
S2 / Web (Desktop scale) spec and incorporating team decisions:

- Wire Epic SWC-2137 throughout.
- Capture the Figma property model (State, Show handle fill, Show color
  loupe) and the box-model note (outer border excluded from handle size).
- Ship the new fill option now (B8); keep open unchanged; keep focused
  unchanged, documenting the RSP focus-vs-click model (enlarge only on
  parent focus, click without parent focus opens the loupe).
- Mark Q1/Q3/Q4/Q5/Q7 resolved; source the adaptive dual-border algorithm
  from the now-present accessibility migration analysis.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…notes

- Update references now that the color-handle accessibility-migration-analysis.md
  is present; mark Q4 resolved and source a11y items from it.
- Resolve Q6: the color-loupe half of SWC-2295 is kept separate and ships as a
  fast-follow PR; out of scope for this migration.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@blunteshwar blunteshwar added the Status:Ready for review PR ready for review or re-review. label Jun 17, 2026
@Rajdeepc Rajdeepc added the 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. Status:Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants