Closed
Conversation
…tion Fixed critical bug where users clicking email verification links crashed due to missing session token checks. Implemented proper Sidecar Session pattern for seamless cross-domain session sharing between legacy BBB and Next.js apps. - Added defensive null checks in verifyMiddleware to handle missing session.token - Implemented cookie synchronization with domain stripping and SameSite=Lax per spec - Fixed hash encoding to use proper hex format instead of comma-separated decimals - Fixed apiCookieHash presence check to match empty string return value - Migrated middleware to use edge-compatible error handler - Added comprehensive documentation for Sidecar Session architecture Note: Hash encoding fix will invalidate existing sessions requiring users to re-authenticate.
- Add IronSessionMock type definition in botCheck.test.ts - Cast ctx.set calls to bypass MSW forbidden header restrictions - Add explicit return types to arrow functions - Disable edge logger in test environment All tests passing (34/34)
- Upgraded Next.js from 15.5.9 to 16.0.10 - Kept React at 18.3.1 for ecosystem compatibility - Upgraded @nivo packages (0.80.0 → 0.99.0) for compatibility **Breaking changes addressed:** - Removed experimental.esmExternals (incompatible with Turbopack) - Removed experimental.newNextLinkBehavior (deprecated) - Removed eslint config from next.config.mjs - Migrated publicRuntimeConfig to NEXT_PUBLIC_API_HOST env var - Migrated serverRuntimeConfig to direct process.env access - Renamed middleware.ts → proxy.ts with proxy() export - Updated .lintstagedrc.mjs to use eslint directly (next lint removed) **Code changes:** - src/api/config.ts: Use env vars directly instead of getConfig() - src/components/Metatags/Metatags.tsx: Use BASE_CANONICAL_URL from process.env - src/types.ts: Removed AppRuntimeConfig interface Build tested successfully with webpack.
shinyichen
approved these changes
Dec 18, 2025
shinyichen
reviewed
Dec 18, 2025
| typeof process.env.NEXT_PUBLIC_API_HOST_CLIENT === 'string' | ||
| ) { | ||
| return process.env.NEXT_PUBLIC_API_HOST_CLIENT; | ||
| // Client-side: use NEXT_PUBLIC_API_HOST |
Member
There was a problem hiding this comment.
I'm not able to test out in localhost, the API host becomes localhost. Was this intentional?
Member
Author
There was a problem hiding this comment.
I'm gonna keep working this one - sorry, I'll convert to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.