fix: Legacy app detection via referer header in SSR#744
Closed
thostetler wants to merge 0 commit intoadsabs:masterfrom
Closed
fix: Legacy app detection via referer header in SSR#744thostetler wants to merge 0 commit intoadsabs:masterfrom
thostetler wants to merge 0 commit intoadsabs:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
========================================
+ Coverage 72.3% 72.4% +0.1%
========================================
Files 221 222 +1
Lines 24801 24928 +127
Branches 1463 1477 +14
========================================
+ Hits 17929 18028 +99
- Misses 6831 6859 +28
Partials 41 41
🚀 New features to boost your workflow:
|
94d4a6a to
8ed72b4
Compare
8ed72b4 to
9678f94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy app detection middleware wasn't working because session changes in middleware weren't visible to GSSP
-- Basically it didn't work inside the middleware, since the session isn't initialized until downstream, so I moved it to ssr-utils for now
Added another commit to add back in the TRACING_HEADERS and to slightly improve the logging in the middleware