Skip to content

Comments

Scix 830 nectar accessibility issues#808

Merged
thostetler merged 7 commits intoadsabs:masterfrom
shinyichen:SCIX-830-nectar-accessibility-issues
Feb 18, 2026
Merged

Scix 830 nectar accessibility issues#808
thostetler merged 7 commits intoadsabs:masterfrom
shinyichen:SCIX-830-nectar-accessibility-issues

Conversation

@shinyichen
Copy link
Member

Address accessibility issues

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.0%. Comparing base (d131c2d) to head (1d40b1d).

Files with missing lines Patch % Lines
...mponents/Visualizations/GraphPanes/MetricsPane.tsx 0.0% 6 Missing ⚠️
src/components/Visualizations/Graphs/Histogram.tsx 0.0% 2 Missing ⚠️
src/components/Pagination/ManualPageSelect.tsx 0.0% 1 Missing ⚠️
...rc/components/ResultList/Pagination/Pagination.tsx 50.0% 1 Missing ⚠️
...rc/components/SearchBar/AllSearchTermsDropdown.tsx 0.0% 1 Missing ⚠️
src/components/Visualizations/Graphs/BarGraph.tsx 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #808     +/-   ##
========================================
- Coverage    62.0%   62.0%   -0.0%     
========================================
  Files         315     315             
  Lines       36392   36401      +9     
  Branches     1631    1632      +1     
========================================
- Hits        22537   22535      -2     
- Misses      13818   13829     +11     
  Partials       37      37             
Files with missing lines Coverage Δ
...ts/CitationExporter/components/ExportContainer.tsx 96.3% <100.0%> (ø)
...ponents/CitationExporter/components/ResultArea.tsx 59.9% <100.0%> (+0.3%) ⬆️
src/components/HistogramSlider/HistogramSlider.tsx 18.0% <ø> (+0.3%) ⬆️
src/components/SearchBar/SearchInput.tsx 83.6% <100.0%> (ø)
src/components/Pagination/ManualPageSelect.tsx 22.2% <0.0%> (ø)
...rc/components/ResultList/Pagination/Pagination.tsx 83.0% <50.0%> (ø)
...rc/components/SearchBar/AllSearchTermsDropdown.tsx 52.6% <0.0%> (-0.2%) ⬇️
src/components/Visualizations/Graphs/BarGraph.tsx 19.6% <0.0%> (ø)
src/components/Visualizations/Graphs/Histogram.tsx 13.8% <0.0%> (-0.1%) ⬇️
...mponents/Visualizations/GraphPanes/MetricsPane.tsx 15.6% <0.0%> (-0.2%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler thostetler merged commit ae1db11 into adsabs:master Feb 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants