Skip to content

Show external link icons in abstract #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shinyichen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show external link icons in abstract #809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions src/components/AbstractDetails/AbstractDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ interface IDetailsProps {
interface IDetailProps<T = string | Array<string>> {
label: string | ReactNode;
href?: string;
newTab?: boolean;
external?: boolean;
value: T;
copiable?: boolean;
children?: (value: T) => ReactElement;
Expand Down Expand Up @@ -98,7 +98,7 @@ export const AbstractDetails = ({ doc }: IDetailsProps): ReactElement => {
label="arXiv"
value={arxiv}
href={createUrlByType(doc?.bibcode, 'arxiv', arxiv?.split(':')[1])}
newTab
external
/>
<Detail label="Bibcode" value={doc.bibcode} copiable />
<Collections collections={doc.database ?? []} />
Expand All @@ -117,7 +117,7 @@ export const AbstractDetails = ({ doc }: IDetailsProps): ReactElement => {

// TODO: this should take in a list of deps or the whole doc and show/hide based on that
const Detail = <T extends string | string[]>(props: IDetailProps<T>): ReactElement => {
const { label, href, newTab = false, value, copiable = false, children } = props;
const { label, href, external = false, value, copiable = false, children } = props;

// show nothing if no value
if (isNilOrEmpty(value)) {
Expand All @@ -131,8 +131,8 @@ const Detail = <T extends string | string[]>(props: IDetailProps<T>): ReactEleme
<Td>{label}</Td>
<Td wordBreak="break-word">
{href && (
<SimpleLink href={href} newTab={newTab}>
{normalizedValue}
<SimpleLink href={href} isExternal={external}>
{normalizedValue} {external && <ExternalLinkIcon aria-label="external link" />}
</SimpleLink>
)}
{typeof children === 'function'
Expand All @@ -159,12 +159,14 @@ const Doi = memo(({ doiIDs, bibcode }: { doiIDs: Array<string>; bibcode: string
<Tooltip
label={
<>
Open DOI link <ExternalLinkIcon />
Open DOI link <ExternalLinkIcon aria-label="external link" />
</>
}
>
<SimpleLink href={createUrlByType(bibcode, 'doi', id)} newTab _hover={{ textDecor: 'underline' }}>
{id}
<Flex alignItems="center">
{id} <ExternalLinkIcon mx={1} />
</Flex>
</SimpleLink>
</Tooltip>
<Tooltip label="Copy DOI" shouldWrapChildren>
Expand Down Expand Up @@ -229,7 +231,13 @@ const UATKeywords = memo(({ keywords, ids }: { keywords: Array<string>; ids: Arr
{keywords.map((keyword, index) => (
<Tag size="md" variant="subtle" whiteSpace="nowrap" m="1" px={2} py={1} key={keyword}>
<HStack spacing="1">
<Tooltip label={keyword}>
<Tooltip
label={
<>
{keyword} <ExternalLinkIcon aria-label="external link" />
</>
}
>
<SimpleLink href={`https://astrothesaurus.org/uat/${encodeURIComponent(ids[index])}`} newTab>
{shortenKeyword(keyword)}
</SimpleLink>
Expand Down Expand Up @@ -305,7 +313,7 @@ const Bibgroups = memo(({ bibgroups }: { bibgroups: Array<string> }) => {
<Tooltip
label={
<>
Click to learn about bibgroups <ExternalLinkIcon />
Click to learn about bibgroups <ExternalLinkIcon aria-label="external link" />
</>
}
>
Expand Down
Loading