Conversation
maximeroucher
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
===========================================
- Coverage 54.15% 10.59% -43.57%
===========================================
Files 169 131 -38
Lines 3741 15972 +12231
===========================================
- Hits 2026 1692 -334
- Misses 1715 14280 +12565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maximeroucher
force-pushed
the
refacto/using-codegen
branch
from
54932b4 to
4adc0c5
Compare
… Json serializable)
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the project to use fully generated classes and repository code based on the Hyperion openapi.json file, improving reliability in API communications.
- Introduces a build.yaml configuration for the swagger_dart_code_generator.
- Updates analysis_options.yaml to exclude generated files from linting.
Reviewed Changes
Copilot reviewed 617 out of 635 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build.yaml | Adds configuration for code generation with default values. |
| analysis_options.yaml | Excludes generated code from analyzer to reduce false positives. |
Files not reviewed (18)
- lib/admin/adapters/core_membership.dart: Language not supported
- lib/admin/adapters/groups.dart: Language not supported
- lib/admin/adapters/module_visibility.dart: Language not supported
- lib/admin/adapters/school.dart: Language not supported
- lib/admin/class/account_type.dart: Language not supported
- lib/admin/class/group.dart: Language not supported
- lib/admin/class/module_visibility.dart: Language not supported
- lib/admin/class/school.dart: Language not supported
- lib/admin/class/simple_group.dart: Language not supported
- lib/admin/providers/account_types_list_provider.dart: Language not supported
- lib/admin/providers/all_account_types_list_provider.dart: Language not supported
- lib/admin/providers/all_groups_list_provider.dart: Language not supported
- lib/admin/providers/group_list_provider.dart: Language not supported
- lib/admin/providers/group_provider.dart: Language not supported
- lib/admin/providers/is_admin_provider.dart: Language not supported
- lib/admin/providers/is_expanded_list_provider.dart: Language not supported
- lib/admin/providers/members_provider.dart: Language not supported
- lib/admin/providers/module_root_list_provider.dart: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MAJOR FLOW]
As some types are nullable in Hyperion and the codegen treat them as dynamic, nested nullable types are cast into JSON when communicating with the API, making the implementation not functional for now !
This is a follow-up of the test : #221
This PR aims to drastically reduce errors while developing and loosing a little time as possible by fully generating classes and repositories codes given the openapi.json file of the corresponding Hyperion, which URL can be changed in the build file.
It adds one command to run the code generation :
dart run build_runner buildand outputs all the code in the generated folder.This PR is a breaking for the development part, since futures modules will be required to align with this design.
This PR gets rid of the tokenExpireWrapper and instead uses request interceptors to re-query a token on expiration.
This PR might force a Hyperion PR, fixing some issues with endpoints, never detected until now, because all the parsing was done by hand.