Repository navigation
compiler: gate capability-bearing module families - #3428
Closed
adilalperenciftci wants to merge 1 commit into
Closed
adilalperenciftci wants to merge 1 commit into
adilalperenciftci wants to merge 1 commit into
Conversation
Signed-off-by: Adil Alperen Çiftci <adilalperenciftci@users.noreply.github.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Collaborator
|
Thanks, reviewed and folded into the batch #3456 with your authorship kept on the commit. This PR will be closed when #3456 merges. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I traced the capability-empty gap to two divergent exact-name classifiers. Alias modules, nested HTTP modules, UDP, dynamic loading, and foreign-language host modules were therefore treated as capability-free even though they expose the same authority as the gated roots.
This change:
--emit=libandae inspect;std.fileandstd.dirasfs;std.udpand nestedstd.http.*modules asnet;std.dlasos;contrib.host.*asextern;--with=fs,net,os,externand updates the embedding documentation.Verification
emit_lib_banned: 12 passed, 0 failed.emit_lib_with_capability: 35 passed, 0 failed.ae_inspect: passed.make test: 634 passed, 0 failed on Ubuntu VM.make check-docs: passed.make check-changelog: passed.The full VM language sweep reached 1931 passed, 11 failed, and 41 skipped. The failures were confined to the VM's unavailable TLS/compression backends, package-mirror fixtures, and the existing
std.zipruntime failure; both changed integration targets passed in that sweep.