Repository navigation
runtime: keep audit entry fields on one snapshot - #3453
Closed
adilalperenciftci wants to merge 1 commit into
Closed
adilalperenciftci wants to merge 1 commit into
adilalperenciftci wants to merge 1 commit into
Conversation
I reproduced the wrapped audit ring advancing between the category, resource, and verdict accessors, which combined fields from different entries. Copy the selected entry under the ring lock and keep the accessor sequence in thread-local storage. Add a synchronized overwrite regression test for the std.audit read order. Signed-off-by: Adil Alperen Çiftci <adilalperenciftci@users.noreply.github.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
nicolas-maman
approved these changes
Oct 30, 2026
Collaborator
|
Thanks @adilalperenciftci! This landed in #3474, which batched nine of your PRs and merged on 2026-10-30 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I reproduced the audit ring advancing between the three field accessor calls used by
std.audit.entry(). Once the ring wrapped, a concurrent append could overwrite the category pointer and shift logical index zero before resource and verdict were read.allowedreads used byaudit.denied_count().Verification
FAIL mixed audit entry: category=cat-new resource=res-001 allowed=1PASS: audit entry fields come from one snapshotsandbox_in_spec_blockpassed.make check-changelogmake check-testsmake test: 634 passed, 0 failedSigned-off-by: Adil Alperen Çiftci adilalperenciftci@users.noreply.github.com