Repository navigation
compiler: fail closed past sandbox stack capacity - #3454
Open
adilalperenciftci wants to merge 1 commit into
Open
adilalperenciftci wants to merge 1 commit into
adilalperenciftci wants to merge 1 commit into
Conversation
I reproduced a 65th sandbox block running without its grant list because the generated 64-slot stack silently discarded the push. Track logical depth past the physical capacity and refuse checks until matching pops or unwind restoration returns to a stored level. Cover the denied inner operation and the restored outer state with an end-to-end regression. Signed-off-by: Adil Alperen Çiftci <adilalperenciftci@users.noreply.github.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I reproduced a 65th
sandbox.enforceblock running without its grant list because the generated permission stack silently discarded pushes beyond its 64 physical slots. An inner empty grant list therefore inherited only the less restrictive outer grants.Verification
overflow-visible=1overflow-visible=0after-visible=1std.sandbox: 14 passingmake check-changelogmake check-testsmake test: 634 passed, 0 failedSigned-off-by: Adil Alperen Çiftci adilalperenciftci@users.noreply.github.com