Repository navigation
test: abi_policy's catalog imports leave no stub directory (#3485) - #3508
Merged
Merged
Conversation
f52e0e7 made a refused binary import remove its stub directory and checked it for the ownership refusals in binary_import_ownership. The catalog refusals (ae_lib_check_compat) go through the same path; abi_policy already builds those catalogs from the real header, so its import_it now gives each import a temp dir of its own (cygpath'd on Windows, as binary_import_ownership does) and fails on a leftover ae-binimport-*. With ae_remove_binimport_stubdirs made a no-op, all five catalog cases fail (major, duty, newer, otherabi, legacy); with main's ae.c they pass. From the closed #3506, which carried this beside a duplicate of the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test-only follow-up to f52e0e7 (#3485), carried over from the closed #3506.
f52e0e7 made a refused binary import remove its stub directory. It checked that for the ownership refusals in
binary_import_ownership. The catalog refusals go through the same exit path inae_lib_check_compat, and they had no such check.abi_policyalready builds those catalogs from the realaether_lib_meta.h(fake_catalog.c). This PR changes only itsimport_ithelper:cygpath -mon Windows, the waybinary_import_ownershipdoes it;ae-binimport-*directory fails the test.That covers five cases: four refusals (another major, an unknown duty, another runtime ABI, a legacy shared runtime) plus a newer minor, which imports.
Verification
ae_remove_binimport_stubdirsmade a no-op in a copy of main'stools/ae.c, all five cases fail, e.g.[FAIL] abi_policy: major: the import left its stub directory (.../major/tmp/ae-binimport-Njz68e).ae.c:[PASS] abi_policy.check-changelog,check-testsandcheck-docspass.🤖 Generated with Claude Code