Repository navigation
Conversation
… their runner CI on the 0.2.1 PR failed in six places, four of them already failing on dev before the audit fixes: - The new OSV audit found GHSA-xmj3-9gf7-h52w (low) in setuptools 84.0.0: the build locks and the Flatpak's build sources now pin 84.1.0 (packaging/update-lock.py --build, same pins otherwise). - test_e2e.RestartTest expected started_by "unknown", but a GitHub runner's jobs run inside its systemd service (INVOCATION_ID and a .service cgroup), so the daemon rightly said "systemd". The end-to-end daemons are now started without INVOCATION_ID or RNFS_STARTED_BY (daemon_environment). - test_tar_stream's cancelled upload: on Windows the send cut off by the daemon's 409 raises ConnectionAbortedError (WSAECONNABORTED), which ApiConnection._early_answer didn't take as a dropped upload, so the client reported a dropped connection instead of the 409. It now does, as for a broken pipe or a reset. - test_public's event watch waited for the add's pin event to be the last one heard; the add's job events may come after it. It now waits for the pin event anywhere after the "lost" marker. - test_api.NameWatchExpiryTest gave a 0.2 s grace with 0.1 s between the watches, which a slow macOS runner overran: now 2 s and 0.5 s. - test_daemon_wait's daemon didn't answer within 60 s on macOS (new with the [::1] listeners). HTTPServer's server_bind looks the address up (socket.getfqdn), which for ::1 can wait on the resolver; BoundedHTTPServer now binds without it (nothing reads server_name), and the test prints the daemon's output if it doesn't start. tests/ci_run.py ran a failed subtest again by its own id, which carries its parameters and loads as an error; it now runs it again by its test's id.
…mproving response management on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools 84.1.0 (GHSA-xmj3-9gf7-h52w), Windows uploads reading the daemon's early answer, and test fixes for the CI runners' environments.