Repository navigation
fix(mcp): say each fact once in a server's detail pane - #1190
Merged
Merged
Conversation
Settings › MCP's server pane repeated itself and mixed fonts: Status and Connection both said "connected", Transport restated the URL, Sign-in restated the Authorization header, tools sat in a row apart from the Tools choice, and the exposure dropdown used the mono font. - Status and Connection are one row: the state once, then what the test or session found; the status's own word only when the state came from elsewhere (a switched-off entry that was tested). - State sentences that restate their label are gone; a dropped connection or a taken name keeps only what to expect or do, after the status lines. - Listed tools go under the Tools row's choice; no Transport row beside a URL or Command; no Sign-in row for an entry with its own Authorization header. - Resources only when there are any; "Ran in" only when the Working directory row does not name that folder; Test points at a refused entry's own line. - One text size (12px UI, dimmer secondary lines), one mono size for literal text (11px), the dropdown in the interface font. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A server's pane in Settings › MCP repeated itself and mixed fonts. After a test of an HTTP server with an
Authorizationheader it read:https://…;Authorization, then Sign-in "Authorization header";Text came in three sizes (12px, 11px secondary lines, 10px tags). Literal text came in two (12px mono URL/path, 11px mono chips). The exposure dropdown used the mono font.
Change
MCP_ROW_STATE_DETAIL_KEYSkeeps onlydisconnectedandconflict, shown after the status lines and cut to what to expect or do.disabled,not-trusted,replaced,overriddenandmcp-offno longer have one.Authorizationheader and noauth.provider; the Headers row lists the header.PI_WEB_PASSWORDentry no longer add a second "nothing to test" line: Test'saria-describedbypoints at the refusal's own line instead..mcp-config-code). Tags are 11px. The exposure dropdown uses the interface font instead of.mcp-add-input's mono.mcp-settings.md,mcp-test-sign-in.md) describe the new layout.After a test, the context7-like case now reads:
Checks
npm test: 2620 tests, 0 failures.tsc --noEmitis clean.eslintis clean on the changed files.McpConfig.test.mjsnow reads the Status row (label + lines) and checks each removed repeat: no Transport row, no header Sign-in row, no "does not connect" sentence, no empty resources, no "Ran in" when it is the working directory, and exactly one line carrying Test's describing id.PI_CODING_AGENT_DIR, local fixture servers). The cases were: HTTP with anAuthorizationheader connected with tools; stdio withcwd/env connected; stdio failing with stderr; OAuth needing sign-in; switched off but tested. Computed fonts fall into UI 12px, UI 12px bold for the state, mono 11px and tags 11px. There is no horizontal overflow at 375px.🤖 Generated with Claude Code