Skip to content

Potential fix for code scanning alert no. 55: Hard-coded cryptographic value #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
whyseu wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Draft

Potential fix for code scanning alert no. 55: Hard-coded cryptographic value #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion rust/src/direct_e2ee/x3dh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,14 @@
.iter()
.flat_map(|chunk| chunk.iter().copied())
.collect::<Vec<_>>();
let prk = hkdf_extract(&[0u8; 32], &ikm);

let mut salt = [0u8; 32];

Check failure

Code scanning / CodeQL

Hard-coded cryptographic value Critical

This hard-coded value is used as
a salt
Loading
.
if let Some(first_chunk) = chunks.first() {
let copy_len = core::cmp::min(first_chunk.len(), salt.len());
salt[..copy_len].copy_from_slice(&first_chunk[..copy_len]);
}

let prk = hkdf_extract(&salt, &ikm);
let initial_secret: [u8; 32] = hkdf_expand_prk(&prk, b"ANP Direct E2EE v1 Initial Secret", 32)?
.try_into()
.map_err(|_| DirectE2eeError::crypto("invalid initial secret length"))?;
Expand Down
Loading