hack: add --help to create-kind-cluster.sh and fix a bashism - #825
Closed
Yuan Gao (ygao-g) wants to merge 1 commit into
Closed
hack: add --help to create-kind-cluster.sh and fix a bashism#825Yuan Gao (ygao-g) wants to merge 1 commit into
Yuan Gao (ygao-g) wants to merge 1 commit into
Conversation
The script is configured entirely through the environment, which was only discoverable by reading it. Add a usage block that names the variables and exits before touching Docker. Also switch the registry's running check from `==` to `=`; the latter is the POSIX test operator and the rest of the script already uses it.
Yuan Gao (ygao-g)
marked this pull request as draft
August 10, 2026 17:54
Collaborator
it's explicitly a bash script, let's use bashism? |
Contributor
Author
|
Fair — dropped it, the line is untouched now. Folded into #827, which is one commit and carries the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hack/create-kind-cluster.sh is configured entirely through the environment, which was only discoverable by reading it. Add a usage block that names the variables and exits before touching Docker, so --help works even where Docker is not running.
Also switch the registry's running check from == to =, the POSIX test operator the rest of the script already uses.
Split out of a larger IPv6 branch so the address-family change that follows is purely about address families.
Testing
hack/create-kind-cluster.sh --helphack/verify/boilerplate.shNo behaviour change to cluster creation.