Remove the secretKeyRef env sources feature - #835
Open
Zoe Zhao (zoez7) wants to merge 1 commit into
Open
Conversation
We don't want actors to have any access to secrets: they will be injected on the egress route instead. Removing this now so we don't need to copy secrets into substrate resources. This reverts the ActorTemplate valueFrom.secretKeyRef support added in agent-substrate#20 (issue agent-substrate#15), surgically rather than via git revert since the touched files have since evolved: - EnvVar reverts to a literal-only {name, value} shape; value is now required. EnvVarSource and SecretKeySelector are gone from the CRD. - ate-api no longer reads Secrets: the env resolver, secret cache, and the kubernetes.Interface plumbing through NewService/NewActorWorkflow are removed. Literal env mapping is folded into workloadSpecFromActorTemplate so it still reaches atelet. - The env redaction in ateinterceptors is kept: it is shared by InternalServerUnaryInterceptor and still keeps literal env values out of request logs. - The claude-code-multiplex demo passes ANTHROPIC_API_KEY as a plain env value substituted at apply time; its Secret object is removed. Note: checkpoint requests (pause/suspend) now carry literal env in the spec since the single builder always maps env; atelet only consumes env on Run/Restore, so this is inert.
Collaborator
|
Can we hold off on this until egress policy merges? We still need some way to get secrets for testing agents which use LLMs |
Collaborator
Author
|
Eitan Yarmush (@EItanya) Do you have ETA for egress policy merge? Once we cut over to substrate resources instead of CRDs, the workflow that rely on the secretKeyRef will break. |
Collaborator
Ok that’s fair, we can just remove it for now, I will review tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the ActorTemplate valueFrom.secretKeyRef support added in #20 (issue #15).
We don't want actors to have any access to secrets, they will be injected on the egress route instead. Removing this now so we don't need to copy secrets into substrate resources.