use FNV-1a as documented in rendezvous hashing - #851
Merged
Benjamin Elder (BenTheElder) merged 1 commit intoAug 12, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request changes the hashing function in rendezvous.go to use fnv.New64a() instead of fnv.New64(). The reviewer points out that using fnv.New64a() with a string-to-byte-slice conversion causes heap allocations, and suggests implementing the FNV-1a algorithm inline to improve performance.
Taahir Ahmed (ahmedtd)
approved these changes
Aug 11, 2026
Benjamin Elder (BenTheElder)
approved these changes
Aug 12, 2026
Benjamin Elder (BenTheElder)
merged commit Aug 12, 2026
38514e7
into
agent-substrate:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The comment on Hasher states the implementation is based on FNV-1a, but fnvhash used fnv.New64() which is FNV-1. Switch to fnv.New64a() to match the documented algorithm and get better distribution.
Why this is safe
The hash function is used solely for live work assignment across controller replicas via rendezvous hashing. No hash values are persisted anywhere.